[PATCH] css: make 'add comment' button look more like a button

Mads Kiilerich mads at kiilerich.com
Tue Apr 21 21:08:16 EDT 2015


On 04/21/2015 01:36 PM, Andrew Shadura wrote:
> # HG changeset patch
> # User Andrew Shadura <andrew at shadura.me>
> # Date 1429637769 -7200
> #      Tue Apr 21 19:36:09 2015 +0200
> # Node ID fe9a1f5d259c186b7d9cd0c3e10aa99217a37fed
> # Parent  c7997c7ed325ddea499549a3d66dc5f006fcba33
> css: make 'add comment' button look more like a button

Some quick comments:

It looks fine. I think there are more important usabilities issues in 
this area and I don't know if this fixes a real problem, but a small 
+something from me for the look of the "button".

The icon should perhaps be centered in the "button box" - now it looks a 
bit weird when "zooming". (We have small similar issues elsewhere but 
this stroke me as more visible.)

However, I don't like that it is hiding text on the current line - that 
is a blocker for me. The least bad options might be to either reserve a 
column for it and show it as bitbucket does or put it on the next line, 
hiding the ("-"?) line number on the line below.

/Mads


More information about the kallithea-general mailing list