[PATCH 0 of 7 WIPv2] Introduction of kallithea-cli command

Thomas De Schampheleire patrickdepinguin at gmail.com
Mon Oct 8 19:57:31 UTC 2018


Hi,

This is v2 of the WIP.

Specific questions about remaining commands:

- gearbox update-repoinfo has following options:
        parser.add_argument('--update-only',
                           action='store',
                           dest='repo_update_list',
                           help="Specifies a comma separated list of repositories "
                                "to update last commit info for. OPTIONAL")
        parser.add_argument('--invalidate-cache',
                           action='store_true',
                           dest='invalidate_cache',
                           help="Trigger cache invalidation event for repos. "
                                "OPTIONAL")

  In fact, this command can do two different things:
  1. update the changeset cache (seemingly a JSON array with changeset
  information)
  2. invalidate the 'cache' of the repository. But this is a different cache
  than the changeset cache above. What the difference exactly is, is unclear
  to me. Enabling this action is steered via '--invalidate-cache'.

  For the new CLI, I would create two separate commands as these things are
  seemingly unrelated, or alternatively group them into one command without
  --invalidate-cache option, i.e. do both 'cache' updates/invalidation
  actions in one go. The latter approach would be good if there is no good
  reason to want one but not the other.

  What do you prefer? How would you name these commands?

- gearbox make-index has following options:

        parser.add_argument('--repo-location',
                          action='store',
                          dest='repo_location',
                          help="Specifies repositories location to index OPTIONAL",
                          )
        parser.add_argument('--index-only',
                          action='store',
                          dest='repo_list',
                          help="Specifies a comma separated list of repositories "
                                "to build index on. If not given all repositories "
                                "are scanned for indexing. OPTIONAL",
                          )
        parser.add_argument('--update-only',
                          action='store',
                          dest='repo_update_list',
                          help="Specifies a comma separated list of repositories "
                                "to re-build index on. OPTIONAL",
                          )
        parser.add_argument('-f',
                          action='store_true',
                          dest='full_index',
                          help="Specifies that index should be made full i.e"
                                " destroy old and build from scratch",
                          default=False)

  Do you know how this command works and what each option does? Could you
  clarify?
  And how should this be untangled in the new CLI?

Thanks,
Thomas


More information about the kallithea-general mailing list