<html><head></head><body>I think using web API calls from hooks might be a good idea<br><br><div class="gmail_quote">Am 19. April 2015 06:56:07 MESZ, schrieb Mads Kiilerich <mads@kiilerich.com>:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On 04/18/2015 03:54 PM, Andrew Shadura wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Hello everyone,<br /><br /> During the last few days I've been trying to develop a patch to implement<br /> email notifications about incoming commits.<br /><br /> The final version of the patch working locally is here, but:<br /><br /> i) it's hardcoded for one email address, i.e. it doesn't have any settings/UI<br /> ii) when I tried to use in on Our Own Kallithea, it broke the whole instance,<br /> presumably in the config initialisation code.<br /><br /> Anyway, I decided to post it here so you comment and maybe fix it :)<br /></blockquote><br />That seems complex. It is impressive you (almost) made it work. But it <br />also seems to suggest that it not is the best approach.<br /><br />How about some other approaches:<br /><br />* letting the hook collect all the info seems
unfortunate; pass enough <br />parameters when configuring the hook for the vcs and let the hook be <br />more self contained<br />* doing it in the same process seems unfortunate; implement a paster <br />command that the hook can call<br />* not having this info available in the environment for vcs commands <br />seems wrong; reorder the wsgi middleware so it also gets defined for vcs <br />operations<br /><br />All the options seems to have disadvantages ... but one of them might be <br />better ...<br /><br />/Mads<br /><hr /><br />kallithea-general mailing list<br />kallithea-general@sfconservancy.org<br /><a href="http://lists.sfconservancy.org/mailman/listinfo/kallithea-general">http://lists.sfconservancy.org/mailman/listinfo/kallithea-general</a><br /></pre></blockquote></div><br>
-- <br>
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.</body></html>