<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/544aa933aea73672259a6834a5f0169db14465ee" style="text-decoration: none; font-weight: bold; color: #573;">e-mail: add trivial test case Add a first trivial e-mail test, new tests to be added in subsequent commits.</a></h1>
<div id="body">
patrickdp committed on 2015-08-02 18:46:17<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/544aa933aea73672259a6834a5f0169db14465ee">544aa933</a><pre>e-mail: add trivial test case
Add a first trivial e-mail test, new tests to be added in subsequent
commits.
A kallithea/tests/other/test_mail.py (46 lines added, 0 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/1339fd56f3020dbf46c922ad27278b9f21c30234" style="text-decoration: none; font-weight: bold; color: #573;">e-mail: revive dead code that checks for unspecified recipients Commit 609e06b6c52f6a8ea9581372805c4bbb60db81a1 introduced dead code: in the beginning of se...</a></h1>
<div id="body">
patrickdp committed on 2015-08-02 19:17:14<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/1339fd56f3020dbf46c922ad27278b9f21c30234">1339fd56</a><pre>e-mail: revive dead code that checks for unspecified recipients
Commit 609e06b6c52f6a8ea9581372805c4bbb60db81a1 introduced dead code:
in the beginning of send_email an assert verifies that recipients is of type
'list', so checking it for None later is useless and that branch can never
be reached.
Instead of removing the dead code, revive it and add a test case.
M kallithea/lib/celerylib/tasks.py (4 lines added, 5 lines removed)
M kallithea/tests/other/test_mail.py (24 lines added, 0 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/88a5fb51d83744befbdb2aaeae63d8c5e735749a" style="text-decoration: none; font-weight: bold; color: #573;">e-mail: properly handle no recipients when there is no email_to set When the configuration file does not contain a value for email_to, and no recipients are...</a></h1>
<div id="body">
patrickdp committed on 2015-08-02 19:25:05<br />branch: default<br />tag: tip<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/88a5fb51d83744befbdb2aaeae63d8c5e735749a">88a5fb51</a><pre>e-mail: properly handle no recipients when there is no email_to set
When the configuration file does not contain a value for email_to, and no
recipients are specified in a call to send_email, recipients would be set to
[None, admins]
which causes an error when logging this list as ' '.join(recipients).
M kallithea/lib/celerylib/tasks.py (10 lines added, 3 lines removed)
M kallithea/tests/other/test_mail.py (22 lines added, 0 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>