<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/bd4840ad72d39d2097e29008b9f39a1b3d5d7b3f" style="text-decoration: none; font-weight: bold; color: #573;">tests: more consistently use unicode where unicode is expected Nothing but extra u annotation to turn str constants into unicode. This has been verified by...</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/bd4840ad72d39d2097e29008b9f39a1b3d5d7b3f">bd4840ad</a><pre>tests: more consistently use unicode where unicode is expected
Nothing but extra u annotation to turn str constants into unicode.
This has been verified by hacking sqlalchemy to fail if wrong string types are passed.
M kallithea/tests/__init__.py (6 lines added, 6 lines removed)
M kallithea/tests/api/api_base.py (62 lines added, 62 lines removed)
M kallithea/tests/fixture.py (5 lines added, 5 lines removed)
M kallithea/tests/functional/test_admin_notifications.py (5 lines added, 5 lines removed)
M kallithea/tests/functional/test_admin_repos.py (23 lines added, 23 lines removed)
M kallithea/tests/functional/test_admin_user_groups.py (5 lines added, 5 lines removed)
M kallithea/tests/functional/test_admin_users.py (15 lines added, 15 lines removed)
M kallithea/tests/functional/test_compare.py (16 lines added, 16 lines removed)
M kallithea/tests/functional/test_files.py (10 lines added, 10 lines removed)
M kallithea/tests/functional/test_forks.py (1 lines added, 1 lines removed)
M kallithea/tests/functional/test_home.py (6 lines added, 6 lines removed)
M kallithea/tests/functional/test_login.py (2 lines added, 2 lines removed)
M kallithea/tests/functional/test_my_account.py (4 lines added, 4 lines removed)
M kallithea/tests/functional/test_pullrequests.py (2 lines added, 2 lines removed)
M kallithea/tests/functional/test_summary.py (2 lines added, 2 lines removed)
M kallithea/tests/models/common.py (13 lines added, 13 lines removed)
M kallithea/tests/models/test_permissions.py (28 lines added, 28 lines removed)
M kallithea/tests/models/test_repo_groups.py (45 lines added, 45 lines removed)
M kallithea/tests/models/test_repos.py (18 lines added, 18 lines removed)
M kallithea/tests/models/test_user_group_permissions_on_repo_groups.py (11 lines added, 11 lines removed)
M kallithea/tests/models/test_user_groups.py (6 lines added, 6 lines removed)
M kallithea/tests/models/test_user_permissions_on_repo_groups.py (12 lines added, 12 lines removed)
M kallithea/tests/models/test_users.py (1 lines added, 1 lines removed)
M kallithea/tests/other/test_mail.py (1 lines added, 1 lines removed)
M kallithea/tests/other/test_validators.py (11 lines added, 11 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/cc8dc30b77f3711aa46c154af9835fcf8787ea80" style="text-decoration: none; font-weight: bold; color: #573;">db: change unicode fields to have Unicode type instead of String Drop convert_unicode for Unicode fields where it doesn't apply; these fields always use uni...</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/cc8dc30b77f3711aa46c154af9835fcf8787ea80">cc8dc30b</a><pre>db: change unicode fields to have Unicode type instead of String
Drop convert_unicode for Unicode fields where it doesn't apply; these fields
always use unicode in the database and returns unicode.
See
<a href="http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode">http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode</a>
for the advice of using Unicode for unicode fields.
M kallithea/model/db.py (13 lines added, 13 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/83f7b5449860d8ee235e1bc0f311b43a11c2b73f" style="text-decoration: none; font-weight: bold; color: #573;">db: stop messing with convert_unicode in .ini and db scheme convert_unicode=False is the default for String fields ... except when the .ini file contains se...</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/83f7b5449860d8ee235e1bc0f311b43a11c2b73f">83f7b544</a><pre>db: stop messing with convert_unicode in .ini and db scheme
convert_unicode=False is the default for String fields ... except when the .ini file contains sets it to True.
String fields are however no longer used for unicode and we can drop convert_unicode everywhere.
See
<a href="http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode">http://docs.sqlalchemy.org/en/latest/core/type_basics.html#sqlalchemy.types.String.params.convert_unicode</a>
for the advice of never setting convert_unicode.
M development.ini (0 lines added, 1 lines removed)
M kallithea/bin/template.ini.mako (0 lines added, 1 lines removed)
M kallithea/config/deployment.ini_tmpl (0 lines added, 1 lines removed)
M kallithea/model/db.py (25 lines added, 25 lines removed)
M kallithea/tests/test.ini (0 lines added, 1 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/b9f4b444a17231476b216d0b2dc444231452dd2f" style="text-decoration: none; font-weight: bold; color: #573;">db: fix uniqueness constraint on the Ui table; it is on the composite key of section and key</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/b9f4b444a17231476b216d0b2dc444231452dd2f">b9f4b444</a><pre>db: fix uniqueness constraint on the Ui table; it is on the composite key of section and key
M kallithea/model/db.py (3 lines added, 5 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/8839e50145dfa39674569b7c8708c96302b41e61" style="text-decoration: none; font-weight: bold; color: #573;">db: consistently use unique=True instead of single column UniqueConstraint</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/8839e50145dfa39674569b7c8708c96302b41e61">8839e501</a><pre>db: consistently use unique=True instead of single column UniqueConstraint
M kallithea/model/db.py (5 lines added, 10 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/7e3336ee19d8e700607718f600b23f5f0f702649" style="text-decoration: none; font-weight: bold; color: #573;">db: drop unique=None and unique=False - that is already the default</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/7e3336ee19d8e700607718f600b23f5f0f702649">7e3336ee</a><pre>db: drop unique=None and unique=False - that is already the default
M kallithea/model/db.py (84 lines added, 84 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/35f2966a5e19a6ec06e24ca1ae26457e748e2c6d" style="text-decoration: none; font-weight: bold; color: #573;">db: drop default=None - that is already the default</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/35f2966a5e19a6ec06e24ca1ae26457e748e2c6d">35f2966a</a><pre>db: drop default=None - that is already the default
M kallithea/model/db.py (74 lines added, 74 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/d553b6d5a8e183972b5539d89b3eb758ada23213" style="text-decoration: none; font-weight: bold; color: #573;">db: primary keys default to not be nullable - don't specify it explicitly</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/d553b6d5a8e183972b5539d89b3eb758ada23213">d553b6d5</a><pre>db: primary keys default to not be nullable - don't specify it explicitly
M kallithea/model/db.py (31 lines added, 31 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/f8a714c2c5a1e1b037d82dd96fec435c9cec6cf8" style="text-decoration: none; font-weight: bold; color: #573;">db: make sure all (non-primary) columns have nullable set explicitly The default of nullable=True is rarely good for us so nullable should always be specifi...</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/f8a714c2c5a1e1b037d82dd96fec435c9cec6cf8">f8a714c2</a><pre>db: make sure all (non-primary) columns have nullable set explicitly
The default of nullable=True is rarely good for us so nullable should always be
specified unless there is a reason to allow nullable ... and if the default is
fine, xplicit is better than implicit.
The declared nulliness of some fields are changed where it seems like code
already enforced it.
Some fields are marked as FIXME when they need (trivial?) data conversion to
convert NULLs to default values.
M kallithea/model/db.py (68 lines added, 68 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/2eaabe413ef6deda0ea6b717402d3a932efe2dd8" style="text-decoration: none; font-weight: bold; color: #573;">lib: drop fuzzy matching on full user names in user_or_none The fallback of checking for matching user names is expensive, untested, fragile, and almost use...</a></h1>
<div id="body">
kiilerix committed on 2016-01-05 15:30:12<br />branch: default<br />tag: tip<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/2eaabe413ef6deda0ea6b717402d3a932efe2dd8">2eaabe41</a><pre>lib: drop fuzzy matching on full user names in user_or_none
The fallback of checking for matching user names is expensive, untested,
fragile, and almost useless.
M kallithea/lib/helpers.py (0 lines added, 5 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>