<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/4a91848040891e276cb336351a14497dd612edc3" style="text-decoration: none; font-weight: bold; color: #573;">comments: linkify revision hashes and issue tracker references This was hard with RST markup - much easier to do reasonably safely in plain text.</a></h1>
<div id="body">
kiilerix committed on 2014-07-04 12:12:07<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/4a91848040891e276cb336351a14497dd612edc3">4a918480</a><pre>comments: linkify revision hashes and issue tracker references
This was hard with RST markup - much easier to do reasonably safely in plain text.
M kallithea/lib/helpers.py (6 lines added, 2 lines removed)
M kallithea/model/notification.py (2 lines added, 2 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (1 lines added, 1 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/872d05f3d7cc46b9743fc17ec4a38db9f88d0c4a" style="text-decoration: none; font-weight: bold; color: #573;">comments: drop preview - no need for it without RST</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/872d05f3d7cc46b9743fc17ec4a38db9f88d0c4a">872d05f3</a><pre>comments: drop preview - no need for it without RST
M kallithea/config/routing.py (0 lines added, 5 lines removed)
M kallithea/controllers/changeset.py (0 lines added, 12 lines removed)
M kallithea/lib/helpers.py (0 lines added, 15 lines removed)
M kallithea/public/css/style.css (0 lines added, 20 lines removed)
M kallithea/public/js/base.js (0 lines added, 26 lines removed)
M kallithea/templates/base/root.html (0 lines added, 1 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (1 lines added, 44 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/12e7421e046967e71bff1ef9b37bf2f4f43866e5" style="text-decoration: none; font-weight: bold; color: #573;">comments: avoid js string formatting of html template from DOM - avoid insecure naming Multiple inline comment forms were only distinguished by the line num...</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/12e7421e046967e71bff1ef9b37bf2f4f43866e5">12e7421e</a><pre>comments: avoid js string formatting of html template from DOM - avoid insecure naming
Multiple inline comment forms were only distinguished by the line number - not
by the filename.
Instead, just keep it simple and avoid trying to assign "globally" unique names
and use jQuery instead.
M kallithea/public/js/base.js (7 lines added, 5 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (3 lines added, 7 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/b3ddd87f214f27df6ca9eb0888dce925a6ff4361" style="text-decoration: none; font-weight: bold; color: #573;">comments: extract common comment creation functionality for changesets and pullrequests So far not big but it will grow later ...</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/b3ddd87f214f27df6ca9eb0888dce925a6ff4361">b3ddd87f</a><pre>comments: extract common comment creation functionality for changesets and pullrequests
So far not big but it will grow later ...
M kallithea/controllers/changeset.py (24 lines added, 9 lines removed)
M kallithea/controllers/pullrequests.py (7 lines added, 9 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/7834f845505aec3086f525600c81209a40b495ef" style="text-decoration: none; font-weight: bold; color: #573;">comments: use inline comment infrastructure for general comments too</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/7834f845505aec3086f525600c81209a40b495ef">7834f845</a><pre>comments: use inline comment infrastructure for general comments too
M kallithea/controllers/changeset.py (11 lines added, 14 lines removed)
M kallithea/public/css/style.css (4 lines added, 0 lines removed)
M kallithea/public/js/base.js (22 lines added, 12 lines removed)
M kallithea/templates/changeset/changeset.html (1 lines added, 2 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (42 lines added, 56 lines removed)
M kallithea/templates/pullrequests/pullrequest_show.html (1 lines added, 4 lines removed)
M kallithea/tests/functional/test_changeset_comments.py (7 lines added, 10 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/2ed9ddab042fd06537c73cbbe6feccb4d0c06e65" style="text-decoration: none; font-weight: bold; color: #573;">comments: fix class of inline comments without context Not really relevant yet(?) but needed for future annotate support.</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/2ed9ddab042fd06537c73cbbe6feccb4d0c06e65">2ed9ddab</a><pre>comments: fix class of inline comments without context
Not really relevant yet(?) but needed for future annotate support.
M kallithea/public/css/style.css (1 lines added, 2 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (5 lines added, 5 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/054c6d98454bb81ef6d49a3a316bd3372a7cdb30" style="text-decoration: none; font-weight: bold; color: #573;">comments: reload after some kinds of general comments - the ones that change the whole page state</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/054c6d98454bb81ef6d49a3a316bd3372a7cdb30">054c6d98</a><pre>comments: reload after some kinds of general comments - the ones that change the whole page state
M kallithea/public/js/base.js (27 lines added, 23 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/1ecfb8ecc634101b63c150beda7473556f05d662" style="text-decoration: none; font-weight: bold; color: #573;">comments: drop delayed activation of new comments It is unclear what it fixed and we have tested this and haven't heard any complaints.</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/1ecfb8ecc634101b63c150beda7473556f05d662">1ecfb8ec</a><pre>comments: drop delayed activation of new comments
It is unclear what it fixed and we have tested this and haven't heard any complaints.
M kallithea/public/js/base.js (4 lines added, 5 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/779d43be59c62422b77e2603d1e86175fa2282a8" style="text-decoration: none; font-weight: bold; color: #573;">pullrequests: make it possible to delete pull requests instead of commenting Deleting a pull request might however be a bad idea - the reviews on the PR wil...</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/779d43be59c62422b77e2603d1e86175fa2282a8">779d43be</a><pre>pullrequests: make it possible to delete pull requests instead of commenting
Deleting a pull request might however be a bad idea - the reviews on the PR
will be lost.
M kallithea/controllers/pullrequests.py (18 lines added, 1 lines removed)
M kallithea/public/js/base.js (30 lines added, 9 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (7 lines added, 0 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/b4b57beb49283931502d5d51d90c69eb7e81f9ba" style="text-decoration: none; font-weight: bold; color: #573;">comments: limit comment deletion to a 5 minutes grace period It is really a bad idea to delete a comment after the content and references to it has been sen...</a></h1>
<div id="body">
kiilerix committed on 2016-01-20 00:47:11<br />branch: default<br />tag: tip<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/b4b57beb49283931502d5d51d90c69eb7e81f9ba">b4b57beb</a><pre>comments: limit comment deletion to a 5 minutes grace period
It is really a bad idea to delete a comment after the content and references to
it has been sent in mails.
Ultimately, comments should be editable and versioned - "delete" should then
just hide the comment.
Note: this is just done at the UI level - not verified on the server
M kallithea/model/db.py (4 lines added, 0 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (4 lines added, 2 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>