<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/712a32f1026bb700a0eab6aa66d5afca6bbc1655" style="text-decoration: none; font-weight: bold; color: #573;">tests: api: fix intertest dependency on repository locking In test classes based on unittest, tests are executed in alphabetical order. In test classes base...</a></h1>
<div id="body">
Thomas De Schampheleire committed on 2016-05-04 06:53:35<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/712a32f1026bb700a0eab6aa66d5afca6bbc1655">712a32f1</a><pre>tests: api: fix intertest dependency on repository locking
In test classes based on unittest, tests are executed in alphabetical order.
In test classes based on pytest, tests are executed in the order they are
specified. This difference revealed a problem in the API tests:
- test_api_lock_repo_lock_optional_locked locks the test repository
- test_api_get_locks_regular_user gets the current locks and expects it to
be empty
With unittest as base class, this worked fine because the 'get_locks' group
of tests are executed before the 'lock_repo' group (alphabetical order).
Using a real pytest-based test class, the order is swapped and the locked
repository from the first test invalidates the preconditions of the second
test.
Fix this specific problem by releasing the lock from
test_api_lock_repo_lock_optional_locked.
This commit does not fix other interdependencies between tests. For example,
test_api_lock_repo_lock_optional_locked expects the existing lock state to
be 'locked' but did not lock the repo itself; instead it expects a previous
test to have locked. In practice, this is
test_api_lock_repo_lock_aquire_optional_userid.
A full solution would make each test fully self contained so that tests can
be executed in random order. The pytest extension pytest-random can help
detecting these problems.
M kallithea/tests/api/api_base.py (19 lines added, 15 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/526724b8b6ce2898a5c4fc4d5ba5295319b968d3" style="text-decoration: none; font-weight: bold; color: #573;">pytest migration: api: convert to TestControllerPytest</a></h1>
<div id="body">
Thomas De Schampheleire committed on 2016-05-02 19:48:04<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/526724b8b6ce2898a5c4fc4d5ba5295319b968d3">526724b8</a><pre>pytest migration: api: convert to TestControllerPytest
M kallithea/tests/api/api_base.py (62 lines added, 49 lines removed)
M kallithea/tests/api/test_api_git.py (2 lines added, 2 lines removed)
M kallithea/tests/api/test_api_hg.py (2 lines added, 2 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/e82963996ae85f0f899a285279d79990f4419f32" style="text-decoration: none; font-weight: bold; color: #573;">tests: users: enable commented UsersController test Previously, a test was written but could not be enabled until pytest was fully available. Now that it's ...</a></h1>
<div id="body">
Thomas De Schampheleire committed on 2016-05-04 15:49:12<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/e82963996ae85f0f899a285279d79990f4419f32">e8296399</a><pre>tests: users: enable commented UsersController test
Previously, a test was written but could not be enabled until pytest
was fully available. Now that it's the case, enable the test.
M kallithea/tests/functional/test_admin_users.py (20 lines added, 23 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/ab36d9a31a2d8f891faca35b4a92ce0d9e694437" style="text-decoration: none; font-weight: bold; color: #573;">pytest migration: add args/kwargs to assertRaises replacement Even though we'll soon get rid of the assertRaises replacement, the tests in kallithea/tests/o...</a></h1>
<div id="body">
Thomas De Schampheleire committed on 2016-05-06 19:20:56<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/ab36d9a31a2d8f891faca35b4a92ce0d9e694437">ab36d9a3</a><pre>pytest migration: add args/kwargs to assertRaises replacement
Even though we'll soon get rid of the assertRaises replacement, the tests in
kallithea/tests/other/test_validators.py expect to pass it args and kwargs
so we need to adapt it first.
M kallithea/tests/__init__.py (2 lines added, 2 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/313930ae35adb377524316074e54828abb5cb17f" style="text-decoration: none; font-weight: bold; color: #573;">pytest migration: other: convert to TestControllerPytest</a></h1>
<div id="body">
Thomas De Schampheleire committed on 2016-05-06 19:21:50<br />branch: default<br />tag: tip<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/313930ae35adb377524316074e54828abb5cb17f">313930ae</a><pre>pytest migration: other: convert to TestControllerPytest
M kallithea/tests/other/manual_test_vcs_operations.py (2 lines added, 2 lines removed)
M kallithea/tests/other/test_libs.py (12 lines added, 11 lines removed)
M kallithea/tests/other/test_mail.py (1 lines added, 1 lines removed)
M kallithea/tests/other/test_validators.py (3 lines added, 6 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>