<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">On 06/30/2016 08:11 PM, Thomas
De Schampheleire wrote:
<br>
<blockquote type="cite" style="color: #000000;">Hi Alessandro,
all,
<br>
<br>
With the current state of the kallithea-tg repo, the test suite
looks
<br>
quite good. There is a large number of failures due to a single
root
<br>
cause: the PUT/DELETE requests not being allowed. I hope Søren
can
<br>
have a look at that, after which many tests will succeed.
<br>
<br>
I'm now looking at the other tests. One specific failure is easy
to
<br>
reproduce, either:
<br>
<br>
$ py.test kallithea/tests/functional/test_changelog.py
<br>
<br>
or interactively by launching kallithea with the test.ini:
<br>
<br>
$ paster serve kallithea/tests/test.ini
<br>
then browsing to one of either repos vce_test_hg/git and then to
'Changelog'.
<br>
<br>
This renders a 500 Server Error without traceback or further
information.
<br>
I was able to zoom in on the problem with manual traces, and
found it
<br>
is related to pagination. If I remove the pagination block from
the
<br>
template (see patch below) then the Changelog page works fine
(except
<br>
for pagination, of course).
<br>
<br>
diff --git a/kallithea/templates/changelog/changelog.html
<br>
b/kallithea/templates/changelog/changelog.html
<br>
--- a/kallithea/templates/changelog/changelog.html
<br>
+++ b/kallithea/templates/changelog/changelog.html
<br>
@@ -160,7 +160,6 @@
<br>
</div>
<br>
<br>
<div class="pagination-wh
pagination-left">
<br>
- ${c.pagination.pager('$link_previous ~2~
$link_next')}
<br>
</div>
<br>
</div>
<br>
</div>
<br>
<br>
<br>
However, it is unclear to me how to proceed. What is the problem
with
<br>
this pagination, why is it a problem under Turbogears2 and not
under
<br>
Pylons? How to see more details about the failures?
<br>
</blockquote>
<br>
Pagination seems odd to me - especially in the current
implementation.
<br>
<br>
It kind of would make sense to have "page with users with names
starting with L-P" or "changesets made 2-5 weeks ago" ... but
labeling a page number 6 and showing item 300 to 350 doesn't make
much sense. Especially because we usually pass all the data to the
template anyway - sometimes even to the client side.
<br>
<br>
Something like the eternal scrolling on <a
class="moz-txt-link-freetext"
href="https://selenic.com/hg/shortlog/"><a class="moz-txt-link-freetext" href="https://selenic.com/hg/shortlog/">https://selenic.com/hg/shortlog/</a></a>
would perhaps be a better solution (except the exponential "page"
navigation).
<br>
<br>
I'm not sure we actually <span class="moz-txt-underscore"><span
class="moz-txt-tag">_</span>need<span class="moz-txt-tag">_</span></span>
"pagination" in other places than the changelog. And perhaps when
listing closed PRs. And notifications and "journal".
<br>
<br>
/Mads
<br>
</div>
</body>
</html>