<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/19/2016 09:34 PM, Thomas De
Schampheleire wrote:<br>
</div>
<blockquote
cite="mid:CAAXf6LVgO6F7Shb-WxXrnqb+bvwZwE7dvDyeH809aTrn+CyaFg@mail.gmail.com"
type="cite">
<p dir="ltr">On Sep 19, 2016 9:30 PM, "Mads Kiilerich" <<a
moz-do-not-send="true" href="mailto:mads@kiilerich.com">mads@kiilerich.com</a>>
wrote:<br>
<br>
>> +from kallithea.tests.base import *<br>
><br>
><br>
> Would you have any objections to dropping this and just use
kallithea.tests.base where it is needed?<br>
><br>
> Import * in general is one thing, but having it in a module
definition can make it even harder to figure out what is going
on.</p>
<p dir="ltr">Does that work with the override of __all__? That is
the real reason to import this way. If there is a better way,
yes please.<br>
</p>
</blockquote>
<p><br>
</p>
<p>We only need __all__ in a module when we do 'import *' from it.
And as I propose it, there would be no 'import *' from __init__.py
but from base.py.</p>
<p>(Also __all__ in base.py will unambiguously be everything, and
there is thus not need for it. Unless we like explicit.)</p>
<p>/Mads<br>
</p>
</body>
</html>