<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/e99a33d7d7f52226df35197aade67125d164d775" style="text-decoration: none; font-weight: bold; color: #573;">cleanup: use obj.foo_id instead of obj.foo.foo_id Don't use constructs like obj.user.user_id when obj.user_id works equally well (and potentially saves a da...</a></h1>
<div id="body">
kwi committed on 2016-09-15 15:22:56<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/e99a33d7d7f52226df35197aade67125d164d775">e99a33d7</a><pre>cleanup: use obj.foo_id instead of obj.foo.foo_id<br /><br />Don't use constructs like obj.user.user_id when obj.user_id works<br />equally well (and potentially saves a database load).
M kallithea/controllers/admin/notifications.py (2 lines added, 2 lines removed)
M kallithea/controllers/admin/repos.py (1 lines added, 1 lines removed)
M kallithea/controllers/changeset.py (1 lines added, 1 lines removed)
M kallithea/controllers/journal.py (4 lines added, 4 lines removed)
M kallithea/controllers/pullrequests.py (4 lines added, 4 lines removed)
M kallithea/model/user_group.py (1 lines added, 1 lines removed)
M kallithea/templates/changeset/changeset_file_comment.html (2 lines added, 2 lines removed)
M kallithea/templates/pullrequests/pullrequest_data.html (1 lines added, 1 lines removed)
M kallithea/templates/pullrequests/pullrequest_show.html (1 lines added, 1 lines removed)
M kallithea/tests/models/test_notifications.py (1 lines added, 1 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/1903d3813ac45e11e5c18b843884b576eb596a32" style="text-decoration: none; font-weight: bold; color: #573;">cleanup: don't "return x if x is not None else None"</a></h1>
<div id="body">
kwi committed on 2016-09-15 16:08:54<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/1903d3813ac45e11e5c18b843884b576eb596a32">1903d381</a><pre>cleanup: don't "return x if x is not None else None"
M kallithea/lib/helpers.py (1 lines added, 3 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/39a59e6915bb398b42c3c2a63c48a950e9d63b55" style="text-decoration: none; font-weight: bold; color: #573;">helpers: refactor and optimize urlify_issues Avoid parsing the configuration and compiling regexps every time a string is processed. Instead, the configura...</a></h1>
<div id="body">
kiilerix committed on 2016-09-25 15:21:07<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/39a59e6915bb398b42c3c2a63c48a950e9d63b55">39a59e69</a><pre>helpers: refactor and optimize urlify_issues<br /><br />Avoid parsing the configuration and compiling regexps every time a string is<br />processed.<br /><br />Instead, the configuration is parsed once and turned into a function that apply<br />the compiled regexps in a chain.<br /><br />A next iteration can perhaps run them in parallel and integrate with the<br />general urlify machinery.
M kallithea/lib/helpers.py (51 lines added, 49 lines removed)
M kallithea/tests/functional/test_files.py (4 lines added, 0 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/e55041bb358551b460c5d7c0503ca17c3bb7c948" style="text-decoration: none; font-weight: bold; color: #573;">diff: don't make '...' a broken link - it doesn't do anything so don't make it a link It would be nice if it could expand it and increase the context size l...</a></h1>
<div id="body">
kiilerix committed on 2016-09-25 15:21:07<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/e55041bb358551b460c5d7c0503ca17c3bb7c948">e55041bb</a><pre>diff: don't make '...' a broken link - it doesn't do anything so don't make it a link<br /><br />It would be nice if it could expand it and increase the context size like<br />bitbucket does ... but that would be a bigger change.
M kallithea/lib/diffs.py (1 lines added, 1 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/d5b837c8b4517679571f8ebf84944765f37504f9" style="text-decoration: none; font-weight: bold; color: #573;">users: use the form URL for POST so the htmlfill error page URL will be the same as the initial form URL. This also reveals that a test used a GET route for...</a></h1>
<div id="body">
kiilerix committed on 2016-09-25 15:21:07<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/d5b837c8b4517679571f8ebf84944765f37504f9">d5b837c8</a><pre>users: use the form URL for POST so the htmlfill error page URL will be the same as the initial form URL.<br /><br />This also reveals that a test used a GET route for POST - they just happened to<br />be the same.<br /><br />These problems can probably be found in many places - there should be a general<br />cleanup.
M kallithea/config/routing.py (1 lines added, 1 lines removed)
M kallithea/templates/admin/users/user_add.html (1 lines added, 1 lines removed)
M kallithea/tests/functional/test_admin_users.py (10 lines added, 9 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/fa85c3df571bc688d5f3b4616f2072f8386c52d3" style="text-decoration: none; font-weight: bold; color: #573;">utils: remove unnecessary import of Session</a></h1>
<div id="body">
kiilerix committed on 2016-09-25 15:21:07<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/fa85c3df571bc688d5f3b4616f2072f8386c52d3">fa85c3df</a><pre>utils: remove unnecessary import of Session
M kallithea/lib/utils.py (1 lines added, 2 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/bcdcdd576e0a46f9659b6290a5d2d0a652161fec" style="text-decoration: none; font-weight: bold; color: #573;">helpers: allow to set class for repo_link breadcrumb links This helps Bootstrap support. (Since this is a high level function that returns several links an...</a></h1>
<div id="body">
domruf committed on 2016-09-15 16:50:30<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/bcdcdd576e0a46f9659b6290a5d2d0a652161fec">bcdcdd57</a><pre>helpers: allow to set class for repo_link breadcrumb links<br /><br />This helps Bootstrap support.<br /><br />(Since this is a high level function that returns several links and not just a<br />single html element, the patch has been modified to only allow specifying a<br />class that is used for all the links.)
M kallithea/lib/helpers.py (4 lines added, 3 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/19c9f4f5428ed35c2be2444ff97ef5d90f3040e8" style="text-decoration: none; font-weight: bold; color: #573;">helpers: rename repo_link to repo_breadcrumps</a></h1>
<div id="body">
kiilerix committed on 2016-09-25 15:42:50<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/19c9f4f5428ed35c2be2444ff97ef5d90f3040e8">19c9f4f5</a><pre>helpers: rename repo_link to repo_breadcrumps
M kallithea/lib/helpers.py (2 lines added, 9 lines removed)
M kallithea/templates/base/base.html (2 lines added, 2 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/d75d9ce1320da84190efda61ce95058bbe9837bb" style="text-decoration: none; font-weight: bold; color: #573;">model: move code from __init__.py to base.py Having too much code, in particular too much imports, inside a package's __init__.py is a recipe for circular i...</a></h1>
<div id="body">
patrickdp committed on 2016-09-25 13:06:34<br />branch: default<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/d75d9ce1320da84190efda61ce95058bbe9837bb">d75d9ce1</a><pre>model: move code from __init__.py to base.py<br /><br />Having too much code, in particular too much imports, inside a package's<br />__init__.py is a recipe for circular imports, and considered bad practice in<br />Python [1]<br /><br />Move out everything from kallithea/model/__init__.py to a new file<br />kallithea/model/base.py and adapt the existing imports.<br /><br />[1] <a href="http://docs.python-guide.org/en/latest/writing/structure/#packages">http://docs.python-guide.org/en/latest/writing/structure/#packages</a>
M kallithea/config/environment.py (1 lines added, 1 lines removed)
M kallithea/lib/celerylib/__init__.py (1 lines added, 1 lines removed)
M kallithea/lib/db_manage.py (1 lines added, 1 lines removed)
M kallithea/lib/hooks.py (1 lines added, 1 lines removed)
M kallithea/lib/paster_commands/common.py (1 lines added, 1 lines removed)
M kallithea/model/__init__.py (0 lines added, 83 lines removed)
M kallithea/model/api_key.py (1 lines added, 1 lines removed)
M kallithea/model/base.py (2 lines added, 2 lines removed)
M kallithea/model/changeset_status.py (1 lines added, 1 lines removed)
M kallithea/model/comment.py (1 lines added, 1 lines removed)
M kallithea/model/gist.py (1 lines added, 1 lines removed)
M kallithea/model/notification.py (1 lines added, 1 lines removed)
M kallithea/model/permission.py (1 lines added, 1 lines removed)
M kallithea/model/pull_request.py (1 lines added, 1 lines removed)
M kallithea/model/repo.py (1 lines added, 1 lines removed)
M kallithea/model/repo_group.py (1 lines added, 1 lines removed)
M kallithea/model/repo_permission.py (1 lines added, 1 lines removed)
M kallithea/model/scm.py (1 lines added, 1 lines removed)
M kallithea/model/user.py (1 lines added, 1 lines removed)
M kallithea/model/user_group.py (1 lines added, 1 lines removed)
M kallithea/tests/scripts/manual_test_concurrency.py (1 lines added, 1 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>
<!DOCTYPE html>
<html>
<head>
</head>
<body style='font: 12pt Roboto, "DejaVu Sans", Arial; margin-left: 5px; margin-right: 5px;'>
<div id="entry">
<h1 style='font: 12pt Roboto, "DejaVu Sans", Arial; display:block; background: #c0cf88; border-bottom: solid 3px #573; padding: 5px; margin-top: 0px; color: #573;'><a href="https://kallithea-scm.org/repos/kallithea/changeset/457f1de3ec5d0e2d38f691606253aaffecb12b91" style="text-decoration: none; font-weight: bold; color: #573;">model: rename db.BaseModel to avoid confusion with base.BaseModel There exist two BaseModel classes in kallithea.model: - kallithea.model.base.BaseModel (pr...</a></h1>
<div id="body">
patrickdp committed on 2016-09-25 13:11:14<br />branch: default<br />tag: tip<br />changeset: <a href="https://kallithea-scm.org/repos/kallithea/changeset/457f1de3ec5d0e2d38f691606253aaffecb12b91">457f1de3</a><pre>model: rename db.BaseModel to avoid confusion with base.BaseModel<br /><br />There exist two BaseModel classes in kallithea.model:<br />- kallithea.model.base.BaseModel (previously kallithea.model.BaseModel)<br />- kallithea.model.db.BaseModel<br /><br />Needless to say, this is very confusing, so rename one of them.
M kallithea/model/db.py (33 lines added, 33 lines removed)</pre>
</div>
</div>
</div>
</body>
</html>