<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi guys,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I cloned the default branch today on our Kallithea test server and when I tried cloning a random repo from our server, I got an HTTP Error: 500 (Internal Server error) and this stack trace:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Traceback (most recent call last):<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support/registry.py", line 253, in __call__<o:p></o:p></p>
<p class="MsoNormal"> app_iter = self.application(environ, start_response)<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support/middlewares.py", line 135, in __call__<o:p></o:p></p>
<p class="MsoNormal"> return self._stream_response(self.app(environ, start_response))<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in __call__<o:p></o:p></p>
<p class="MsoNormal"> return self._handle_request(environ, start_response)<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea/kallithea/lib/middleware/simplegit.py", line 69, in _handle_request<o:p></o:p></p>
<p class="MsoNormal"> return self.application(environ, start_response)<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in __call__<o:p></o:p></p>
<p class="MsoNormal"> return self._handle_request(environ, start_response)<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 143, in _handle_request<o:p></o:p></p>
<p class="MsoNormal"> self._augment_hgrc(repo_path, baseui)<o:p></o:p></p>
<p class="MsoNormal"> File "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 229, in _augment_hgrc<o:p></o:p></p>
<p class="MsoNormal"> for k, v in repoui.configitems(section):<o:p></o:p></p>
<p class="MsoNormal">AttributeError: 'bool' object has no attribute 'configitems'<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I checked the latest commits and I think the issue may be related to this one:
<a href="https://kallithea-scm.org/repos/kallithea/changeset/89c30b145bb8a4151c1154c42c4e9ec23ff442f8">
https://kallithea-scm.org/repos/kallithea/changeset/89c30b145bb8a4151c1154c42c4e9ec23ff442f8</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">If I add back line 240 (if repoui: ) which was removed from simplehg.py and I keep the other changes from the commit everything works, but if I comment that line I get the ‘bool’ exception.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Can you confirm?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Mat<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>