<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">We landed the fix as
<a class="moz-txt-link-freetext" href="https://kallithea-scm.org/repos/kallithea/changeset/f950740985f47ea09ef3361fa56b3d7581429156">https://kallithea-scm.org/repos/kallithea/changeset/f950740985f47ea09ef3361fa56b3d7581429156</a></div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Thanks,</div>
<div class="moz-cite-prefix">Mads</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 12/15/20 4:10 PM, Brett Smith wrote:<br>
</div>
<blockquote type="cite"
cite="mid:185dc897-a201-abc6-ef01-0279f55b6eb0@sfconservancy.org">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">On 12/14/20 5:15 PM, Mads Kiilerich
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d296f27f-72c4-0f18-8bfc-883b4c5c9582@kiilerich.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<div class="moz-cite-prefix">Ouch, yeah, .splitlines() is
confusingly different from .split('\n') . Thanks for the
patch.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Would it perhaps be better to just
use .split instead of .splitlines()?<br>
</div>
</blockquote>
<p>Your call but on balance I do think splitlines is better. It
splits on <a moz-do-not-send="true"
href="https://docs.python.org/3/library/stdtypes.html#str.splitlines">all
kinds of Unicode line separators</a>, not just \n, and I think
that's good when you're dealing with very arbitrary user text
like this.</p>
<blockquote type="cite"
cite="mid:d296f27f-72c4-0f18-8bfc-883b4c5c9582@kiilerich.com">
<div class="moz-cite-prefix"> </div>
<div class="moz-cite-prefix">But since the commit message text
is shown as a link, would it perhaps be even better to avoid
the void and show a text like "(No commit message)"?</div>
</blockquote>
<p>I think that would be nice. It wasn't in my patch because I
wasn't sure what all was involved with adding a new message
string to the code, but if you can make it happen I think it
would be worth it.</p>
<p>In general I didn't think my patch was thorough enough to apply
directly to the code. I sent it just to communicate exactly
where I found the bug.</p>
<p>Thanks,<br>
</p>
<div class="moz-signature">-- <br>
Brett Smith</div>
</blockquote>
<p><br>
</p>
</body>
</html>