[PATCH 0 of 2 RFC] pullrequests: add unittests

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Feb 21 14:13:41 EST 2015


This RFC is the beginning of adding a set of unittests for the existing
behavior in _get_repo_refs.

I would like to get feedback on the following:

a. general feedback on the current code

b. the next batch of tests is supposed to verify the behavior of
_get_repo_refs for pull requests from a branch. For this I need to add a
branch to the repository in the test, but I'm unsure how I should do this.
Any help is appreciated here.
Similar question for adding bookmarks (hg only?) and tags.

Partially related to b. a good explanation on the repository handling in
Kallithea is very welcome: there is obviously the real repository on
filesystem, but in Kallithea I see different classes:
- Repository
- RepoModel
- BaseRepository
How does all of this fit together?


More information about the kallithea-general mailing list