[PATCH] my pull requests: fix page title when no site branding is set

Mads Kiilerich mads at kiilerich.com
Tue Feb 24 18:02:17 EST 2015

On 02/23/2015 10:17 PM, Thomas De Schampheleire wrote:
>>>> root.html has some special hacks for using c.repo_name when it is
>>>> defined.
>>>> For now I think it would be fine to handle branding and repo name the
>>>> same
>>>> way.
>>>> (A related "feature request": People often have multiple tabs open and
>>>> they
>>>> only see 10 characters of the page title. They want to see the most
>>>> important info there so they can tell them apart. But for some users that
>>>> will be the hostname/branding, for others it will be the repo name, for
>>>> others it will be the branch name, for others it will be the pull request
>>>> number or name (when applicable). I don't see a good solution to that.
>>>> But
>>>> let's keep the branding at the end.)
>>> And here your feature request is to keep the branding at the end?
>>> Or would the feature be the configuration of the page title based on
>>> some %foo modifiers?
>> I don't know a good solution but I kind of understand the problem. You can
>> perhaps help keeping it in mind and see if a solution / improvement pops up.
> I really think we should write such things down somewhere, instead of
> having it in your and my mind only.

Fine with me ... but I doubt I will be good at writing it in a 
structured way or use it. It is not like any of us can manage others and 
tell them what to do. Your ideas might be different and better than mine 
... and my ideas and thoughts might be different the day after when I 
have discussed it or learned or thought more about it.

I think it would be great if you could help getting such a process 
going. (I also think we can keep doing a great job by just continuously 
attacking what we consider most important from our perspective, and 
discuss things on demand.)


More information about the kallithea-general mailing list