[PATCH] changelog: repeat pager links on top of changelog

Mads Kiilerich mads at kiilerich.com
Fri Mar 6 11:29:45 EST 2015


On 03/04/2015 10:06 PM, Thomas De Schampheleire wrote:
> # HG changeset patch
> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> # Date 1425503195 -3600
> #      Wed Mar 04 22:06:35 2015 +0100
> # Node ID ed66618ffb23900e1cf56add90f54801e455a0eb
> # Parent  297d798bd5b22ea562d0813bed7e5eb6bc646c1b
> changelog: repeat pager links on top of changelog
>
> In particular since the default number of entries in the changelog has been
> increased to 100, having the pager links both above and below the changelog
> is more user-friendly.

When will the user ever be looking at the top of a multi-page listing of 
changesets and without seeing the end of the current page know that he 
has to navigate to the next one ... or 4 pages forward?

(I dislike paging - especially when the items on pages don't have 
"primary keys" that gives a natural paging. I would much rather have 
automatic loading of an extra chunk when scrolling to the bottom of the 
page.)

/Mads

>
> diff --git a/kallithea/templates/changelog/changelog.html b/kallithea/templates/changelog/changelog.html
> --- a/kallithea/templates/changelog/changelog.html
> +++ b/kallithea/templates/changelog/changelog.html
> @@ -73,6 +73,10 @@
>   
>                   <div id="changelog" style="clear:both">
>   
> +                <div class="pagination-wh pagination-left">
> +                    ${c.pagination.pager('$link_previous ~2~ $link_next')}
> +                </div>
> +
>                   <div id="graph_nodes">
>                       <canvas id="graph_canvas"></canvas>
>                   </div>
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> http://lists.sfconservancy.org/mailman/listinfo/kallithea-general



More information about the kallithea-general mailing list