[PATCH] comments: avoid confusing 'No comments' on empty general comments

Mads Kiilerich mads at kiilerich.com
Sat Apr 18 18:37:17 EDT 2015

On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote:
> # HG changeset patch
> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> # Date 1429294302 -7200
> #      Fri Apr 17 20:11:42 2015 +0200
> # Node ID e25ee448dae32e2e21f1b66763dae468f45c00f0
> # Parent  a7cc66bf51ec89134cb7b02aca044bb74a56f768
> comments: avoid confusing 'No comments' on empty general comments
> When a general comment (with or without status change) is added to a changeset
> or pull request, and no text was added, Kallithea automatically used 'No
> comments' as text. This is confusing when the reviewer has added one or more
> inline comments.

Ok, it is not really 'no comments' in that case. Still, the status 
change is done without an explicit comment to that. We can perhaps be 
more spot on.

Also, right now, each comment (inline or global) is added separately. I 
can see how your change would make more sense together with Jan's 
draft/submit changes.

> Instead, use '(status change only)'.

It will show up as a comment so let's use proper casing and punctuation. 
How about "Status change without comment." or "Status change." and later 
on "Status change with inline comments."?

> In the case where a user added
> a comment without text and without status change (for example when closing a
> pull requesh), use '(no comments added)'.

There is no reason to add comments without text and without status 
change and without closing. If it is closing, how about "Closing without 
comment." ?

> Currently there is a large amount of duplication between
> controllers/changeset.py and controllers/pullrequests.py, which is to be
> cleaned up in a later commit.

That would be wonderful!


More information about the kallithea-general mailing list