[PATCH 0 of 7] save multiple comments at once

Jan Heylen heyleke at gmail.com
Sun Apr 19 13:11:02 EDT 2015

On Sun, Apr 19, 2015 at 6:37 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
> On 04/19/2015 06:18 AM, Jan Heylen wrote:
>> Hi,
>> anybody some spare time to have a look at these patches?
> I haven't had as much time as it deserves.
> My main unsolicited thought is that I would see this as something closely
> related to having versioning of comments so they can be edited or deleted
> while leaving history tracks. A draft comment would be something that
> haven't been made active yet. I am not entirely sure what datamodel would
> fit that need but it seems to me like we should implement edit+delete before
> draft ... or at least design them together.

If you would like versioned comments, that would be a very different
story, that would/could mean that you put your comments in a version
control system, e.g. mercurial ;-p, but I believe that could still be
another step, and I'm more in favor of taking it step by step. What do
you think of changing the workflow as presented in this patch series,
where you first issue multiple comments as 'drafts' (already saved in
the database) and as a last step, give your judgement
(approve/reject/under review/...) and thereby also publish your drafts
(+email notification).

> A very related question is getting a full overview of which data model we
> would like to use for "pull requests" and comments.

I don't have the intention to define a full new data model, I'm
extending the one used at the moment, which in my believe is fine for
the time being. And yes, it has its drawbacks, and there are other
(rather complex) models out there, but one of the strengths of
Kallithea in my belief is, is that is fairly simple and adaptable, but
upstreaming these modifications without breaking some other flavor,
that looks like one of the challenges. So,that's why I ask, should
this be configurable?


> /Mads

More information about the kallithea-general mailing list