[PATCH] css: make 'add comment' button look more like a button

Thomas De Schampheleire patrickdepinguin at gmail.com
Tue Apr 21 15:47:43 EDT 2015


On April 21, 2015 7:36:24 PM CEST, Andrew Shadura <andrew at shadura.me> wrote:
># HG changeset patch
># User Andrew Shadura <andrew at shadura.me>
># Date 1429637769 -7200
>#      Tue Apr 21 19:36:09 2015 +0200
># Node ID fe9a1f5d259c186b7d9cd0c3e10aa99217a37fed
># Parent  c7997c7ed325ddea499549a3d66dc5f006fcba33
>css: make 'add comment' button look more like a button
>
>diff --git a/kallithea/public/css/style.css
>b/kallithea/public/css/style.css
>--- a/kallithea/public/css/style.css
>+++ b/kallithea/public/css/style.css
>@@ -4971,10 +4971,12 @@ table.code-difftable .code pre {
> }
> 
> .add-bubble {
>+    position: relative;
>     display: none;
>     float: left;
>     width: 0px;
>     height: 0px;
>+    left: -8px;
> }
> 
> tr.line.add td.code:hover .add-bubble,
>@@ -4984,20 +4986,26 @@ tr.line.unmod td.code:hover .add-bubble 
> }
> 
> .add-bubble div {
>-    position: relative;
>-    left: -32px;
>-    width: 32px;
>-    height: 32px;
>+    background: #577632;
>+    width: 16px;
>+    height: 16px;
>     cursor: pointer;
>+    padding: 0 2px 2px 0;
>+    border: 1px solid #577632;
>+    border-radius: 3px;
> }
> 
> .add-bubble div:before {
>     font-size: 14px;
>-    color: #577632;
>+    color: #ffffff;
>     font-family: "kallithea";
>     content: '\1f5ea';
> }
> 
>+.add-bubble div:hover {
>+    transform: scale(1.2, 1.2);
>+}
>+
> div.comment:target>.comment-wrapp {
>     border: solid 2px #ee0 !important;
> }

Do you happen to have a live preview or a before/after image?

There has been previous debate about what to do with this button, where to 
place it, and in particular the fact that you can't click it when moving the mouse from 
the left. This is also an issue tracked on bitbucket.

>_______________________________________________
>kallithea-general mailing list
>kallithea-general at sfconservancy.org
>http://lists.sfconservancy.org/mailman/listinfo/kallithea-general




More information about the kallithea-general mailing list