[PATCH] Issue #126: Improve UX for setting a remote repo
Andrew Shadura
andrew at shadura.me
Wed Apr 22 07:57:48 EDT 2015
Hello,
On Wed, 22 Apr 2015 11:52:59 +0100
Mads Kiilerich <mads at kiilerich.com> wrote:
> > + <div class="fields">
> > + ${h.submit(
> > + 'remote_pull_%s' % c.repo_info.repo_name,
> > + _('Pull Changes from Remote Repo'),
> > + class_="btn btn-small",
> > + onclick="return confirm('"
> > + + _('Confirm to pull changes from remote
> > repository.')
> > + + "');")}
>
> Let's hope no languages use ' in the translation of that string ;-)
>
> I think the mix of python and javascript would be more readable with
> a % formatter ... and javascript and python are so close that %r
> might be better than manual quoting.
I can imagine at least Belarusian to use an apostrophe here… So it's
better to quote it somehow :)
--
Cheers,
Andrew
More information about the kallithea-general
mailing list