[PATCH] compat: import defaultdict from collections, sqlalchemy 0.8.0 dropped the shim

Mads Kiilerich mads at kiilerich.com
Wed Apr 22 12:56:04 EDT 2015


On 04/21/2015 07:04 PM, Andrew Shadura wrote:
> # HG changeset patch
> # User Andrew Shadura <andrew at shadura.me>
> # Date 1429635852 -7200
> #      Tue Apr 21 19:04:12 2015 +0200
> # Branch stable
> # Node ID 74b5e0318d4e961081daca2833c4ffe520e59e62
> # Parent  7aef2c2289c8a1ee450d7f8624e731d7c89d99d3
> compat: import defaultdict from collections, sqlalchemy 0.8.0 dropped the shim

lgtm ... but why not just remove this redundant compat wrapper instead?

/Mads

>
> diff --git a/kallithea/model/comment.py b/kallithea/model/comment.py
> --- a/kallithea/model/comment.py
> +++ b/kallithea/model/comment.py
> @@ -28,7 +28,7 @@ Original author and date, and relevant c
>   import logging
>   
>   from pylons.i18n.translation import _
> -from sqlalchemy.util.compat import defaultdict
> +from collections import defaultdict
>   
>   from kallithea.lib.utils2 import extract_mentioned_users, safe_unicode
>   from kallithea.lib import helpers as h
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> http://lists.sfconservancy.org/mailman/listinfo/kallithea-general



More information about the kallithea-general mailing list