[PATCH 2 of 2] css: add text +/- markers to the diff to improve readability for colour blind (fixes #77)

[Mads Kiilerich]

On 04/22/2015 02:20 PM, Andrew Shadura wrote:
> # HG changeset patch
> # User Andrew Shadura <andrew at shadura.me>
> # Date 1429705229 -7200
> #      Wed Apr 22 14:20:29 2015 +0200
> # Branch stable
> # Node ID a06804c28d744fb153c3e083277429094a134495
> # Parent  539f3da5d965459d2221d10b6724585e60104f7d
> css: add text +/- markers to the diff to improve readability for colour blind (fixes #77)

This seems unrelated to 
https://bitbucket.org/conservancy/kallithea/issue/77 ?

Do we really want to make the diff look so much more like the normal 
diff format? I kind of consider it a feature that the changes shows up 
more cleanly.

A column with +/- needs eye flickering to parse when looking at the 
actual changes elsewhere on the lines. It might be nice to have for 
those who are used to the format but we shouldn't rely on it or make 
colorblind rely on it we can avoid it.

I don't know how good or bad the colors are for the different kinds of 
color blindness. Is it solving a real problem? I think it would be a 
better help for color blind if we made sure that the deleted lines were 
darker (and thus with lower contrast) and the context lines were 
brighter (and thus with lower contrast) so the actually changed lines 
stood out most clearly.

Anyway: Do we need to use yet another column of the precious horizontal 
space for this purpose? Couldn't it reuse the new empty column where the 
comment bubble might show up?

/Mads


>
> diff --git a/kallithea/public/css/style.css b/kallithea/public/css/style.css
> --- a/kallithea/public/css/style.css
> +++ b/kallithea/public/css/style.css
> @@ -4964,6 +4964,20 @@ table.code-difftable .code pre {
>       white-space: pre-wrap;
>   }
>   
> +table.code-difftable .del .code pre:before {
> +    content: "-";
> +    color: #550000;
> +}
> +
> +table.code-difftable .add .code pre:before {
> +    content: "+";
> +    color: #005500;
> +}
> +
> +table.code-difftable .unmod .code pre:before {
> +    content: " ";
> +}
> +
>   .add-bubble {
>       position: relative;
>       display: none;
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> http://lists.sfconservancy.org/mailman/listinfo/kallithea-general