[PATCH] diff view: improve appearance of line numbers

Andrew Shadura andrew at shadura.me
Wed May 6 10:58:48 EDT 2015


On Wed, 06 May 2015 16:52:08 +0200
Mads Kiilerich <mads at kiilerich.com> wrote:

> Thanks for the clarification and the thoughts about how applicable it
> is for our use.

> Box-sizing seems to still be experimental and sems risky. Does it
> work reliably across all the browsers we care about? How seriously
> will it fail if it doesn't work?

> I guess bootstrap added the necessary quirks to make it for their
> case - we don't need additional quirks too?

Indeed, adding -webkit- and -moz- prefixes might help with older
browser versions.

> Some of this would be nice to have in commit messages ... perhaps
> except the education of me ;-) It would also be nice to have it split
> it up in separate changes ... but perhaps without going to the smf
> extreme ;-)

> With these comments addressed, it looks good to me.

Okay, I'll try to write something up.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20150506/72f1ceee/attachment.sig>

More information about the kallithea-general mailing list