[PATCH] auth: let users log in using their email address

Andrew Shadura andrew at shadura.me
Sat May 16 09:53:34 EDT 2015


On Fri, 15 May 2015 23:52:27 +0200
Mads Kiilerich <mads at kiilerich.com> wrote:

> On 05/15/2015 07:06 PM, Andrew Shadura wrote:
> > # HG changeset patch
> > # User Andrew Shadura <andrew at shadura.me>
> > # Date 1431709586 -7200
> > #      Fri May 15 19:06:26 2015 +0200
> > # Node ID 1a7787acd1276557128ac6f8cd274b39c86ebbae
> > # Parent  95bffe63997d40bfab5ae6b8d1a54859d6275471
> > auth: let users log in using their email address

> Nice and simple - thanks!

> This will however crash if the user specifies an invalid email
> address.

Noted — and fixed.

> This feature also seems a bit half-baked when it only is for web
> login. Hg/git login should work the same way.

Possibly, but I think that would be a good think to work on in a next

> FWIW: The only other place where users have to care about their (and 
> others) "login" is in @mention. It would be nice to be able to
> specify email addresses there too. @username at example.com should work
> in the scanner (regexp) and auto completer. Some users would perhaps
> prefer to avoid exposing their email address so it should perhaps be
> configurable somehow ... but I'm pretty sure we already expose email
> addresses in other places so such a "privacy" option would be a
> separate feature.

Well, this is something I'm not so sure about… Mentions should rather
work with Real Names (autocompleting them to the login names, possibly
expanding to a Real Name on display), but I don't think autocompletion
should be done to email addresses. But let's address that later on,
it's a bigger topic on its own.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20150516/4c9160e9/attachment.sig>

More information about the kallithea-general mailing list