[PATCH 8 of 8 v2] drafts: emphasize the users attention on his drafts

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat May 16 16:35:45 EDT 2015


On Sat, May 16, 2015 at 2:02 PM, Jan Heylen <heyleke at gmail.com> wrote:
> # HG changeset patch
> # User Jan Heylen <heyleke at gmail.com>
> # Date 1428987893 -7200
> #      Tue Apr 14 07:04:53 2015 +0200
> # Node ID 88a6cdc7a8700dc05d443768e876a7c8d13ef14b
> # Parent  f119d10ce90f342131b52a3751e697236523f413
> drafts: emphasize the users attention on his drafts
>
> diff -r f119d10ce90f -r 88a6cdc7a870 kallithea/public/css/style.css
> --- a/kallithea/public/css/style.css    Sat May 16 08:39:48 2015 +0200
> +++ b/kallithea/public/css/style.css    Tue Apr 14 07:04:53 2015 +0200
> @@ -4546,6 +4546,29 @@
>      padding: 3px;
>  }
>
> +.inline-comments .comment .meta-draft {
> +    background: #98fb98;
> +    padding: 4px;
> +    border-bottom: 1px solid #ddd;
> +    min-height: 20px;
> +    overflow: auto;
> +}
> +
> +.inline-comments .comment .meta-draft img {
> +    vertical-align: middle;
> +}
> +
> +.inline-comments .comment .meta-draft .user {
> +    font-weight: bold;
> +    float: left;
> +    padding: 3px;
> +}
> +
> +.inline-comments .comment .meta-draft .date {
> +    float: left;
> +    padding: 3px;
> +}
> +

You can remove all of this duplication except the background color
change by giving the 'draft' class in addition to 'meta', rather than
creating a new class 'meta-draft'.

>  .inline-comments .comment .text {
>      background-color: #FAFAFA;
>  }
> diff -r f119d10ce90f -r 88a6cdc7a870 kallithea/templates/changeset/changeset_file_comment.html
> --- a/kallithea/templates/changeset/changeset_file_comment.html Sat May 16 08:39:48 2015 +0200
> +++ b/kallithea/templates/changeset/changeset_file_comment.html Tue Apr 14 07:04:53 2015 +0200
> @@ -6,7 +6,11 @@
>  <%def name="comment_block(co)">
>    <div class="comment" id="comment-${co.comment_id}" line="${co.line_no}">
>      <div class="comment-wrapp">
> +      %if co.draft:
> +      <div class="meta-draft">
> +      %else:
>        <div class="meta">
> +      %endif
>            <div style="float:left">
>                 ${h.gravatar(co.author.email, size=20)}
>            </div>


More information about the kallithea-general mailing list