[PATCH] utils: return 'never' when the age is None

Andrew Shadura andrew at shadura.me
Tue May 26 03:27:21 EDT 2015


Hello,

On Fri, 22 May 2015 02:58:09 +0200
Mads Kiilerich <mads at kiilerich.com> wrote:

> On 05/21/2015 08:15 PM, Andrew Shadura wrote:
> > # HG changeset patch
> > # User Andrew Shadura <andrew at shadura.me>
> > # Date 1432232093 -7200
> > #      Thu May 21 20:14:53 2015 +0200
> > # Node ID 3737e67c7cbb89750dd8b3b5f76a003678792f3f
> > # Parent  8d43a8174c960779437c2d8de7a0906a8cd14128
> > utils: return 'never' when the age is None

> As far as I understand, this can never happen "from scratch" - only
> from updates. That should be mentioned in the commit message.

> Anyway, I think it would be much better to fix missing db upgrade
> steps by adding the missing steps to the latest db upgrade step (in a 
> non-destructive way, of course).

I'm not so sure about this… We have the column declared as accepting
NULLs, so we should probably have a way of displaying this valid value.
Itself it doesn't break anything, so it's possible there's no need to
change the upgrade procedure.

-- 
Cheers,
  Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20150526/986b1b95/attachment.sig>


More information about the kallithea-general mailing list