[PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)
Thomas De Schampheleire
patrickdepinguin at gmail.com
Sat Jun 13 02:46:50 EDT 2015
On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich <mads at kiilerich.com> wrote:
>On 06/11/2015 10:59 AM, Thomas De Schampheleire wrote:
>> # HG changeset patch
>> # User Thomas De Schampheleire
><thomas.de_schampheleire at alcatel-lucent.com>
>> # Date 1432734170 -7200
>> # Wed May 27 15:42:50 2015 +0200
>> # Node ID d63188974baec38503601ef0efd33a75711280a2
>> # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2
>> comments: remove dysfunctional comment bubble on compare and file
>views (issue #84)
>> Several compare and file views would show a comment bubble when
>> lines, even though clicking on this bubble would not do anything.
>> Instead, make sure that the bubble only appears on pages that attach
>> action to the bubble (pullrequest and changeset pages), by splitting
>> add-bubble CSS class in add-bubble (enabled when needed) and
>> add-bubble-placeholder (always present).
>> This change is inspired by code from Wouter Vermeiren.
>Wouldn't it be simpler to let css (or jquery) restrict the bubble magic
>to some page types (and thus different classes of some outer diffs)?
I'm not sure if that with simpler: it requires more nesting if the css rules, somewhat fragile when the html would be reorganized.
Also, it requires that there actually are unique outer diffs for the relevant cases.
>(I have a dream: Make annotate use "blame" to find the original
>changeset to comment on, thus making comments on any file view
We have the same dream!
More information about the kallithea-general