[PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"
heyleke at gmail.com
Tue Jun 16 14:44:57 EDT 2015
On Tue, Jun 16, 2015 at 8:39 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
> On 06/16/2015 08:31 PM, Jan Heylen wrote:
>> # HG changeset patch
>> # User Jan Heylen <heyleke at gmail.com>
>> # Date 1434479490 -7200
>> # Tue Jun 16 20:31:30 2015 +0200
>> # Node ID 3ff99546a950144258be3078b4483e7cebd5d720
>> # Parent 53d68f201e4602d3f2ccfcd27107d2ebea2deea2
>> backout "pullrequests: don't add automatic 'status change' message - it
>> will be added in template"
>> this commit causes following simple test to fail:
>> * start from empty database with 2 repos, one a fork of the other, 1
>> commit diff
>> * create a new pull request with that one commit
>> * after the pull request is created, immediatly click on the link to the
>> in the pull request content list
>> --> error with undefined comments variable
> Wouldn't it be better to fix that error?
Maybe the original author of that commit can have a look ;-)
No serious. I think it is more important that this does not stay in as
it is now, step 1 is backing out this change, as it breaks stuff.
Fixing it would require some more time and discussion.
But this patch can serve as a discussion thread on how you want this
to be fixed... (concerning all loops over comments in the templates
that can go wrong)
>> diff -r 53d68f201e46 -r 3ff99546a950 kallithea/model/pull_request.py
>> --- a/kallithea/model/pull_request.py Mon Jun 08 06:46:48 2015 +0200
>> +++ b/kallithea/model/pull_request.py Tue Jun 16 20:31:30 2015 +0200
>> @@ -93,7 +93,7 @@
>> #reset state to under-review
>> from kallithea.model.comment import ChangesetCommentsModel
>> comment = ChangesetCommentsModel().create(
>> - text=u'',
>> + text=u'Auto status change to %s' %
>> kallithea-general mailing list
>> kallithea-general at sfconservancy.org
More information about the kallithea-general