[PATCH 5 of 7] tests: remove hardcoded test passwords
Thomas De Schampheleire
patrickdepinguin at gmail.com
Sat Jun 20 16:37:58 EDT 2015
# HG changeset patch
# User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
# Date 1434830216 -7200
# Sat Jun 20 21:56:56 2015 +0200
# Node ID 95518c56b04c78511c7e003b6a02337e32d7c8e0
# Parent 359e871608759bf729ad8378be00f3a3bf677942
tests: remove hardcoded test passwords
diff --git a/kallithea/tests/functional/test_login.py b/kallithea/tests/functional/test_login.py
--- a/kallithea/tests/functional/test_login.py
+++ b/kallithea/tests/functional/test_login.py
@@ -31,7 +31,7 @@ class TestLoginController(TestController
def test_login_admin_ok(self):
response = self.app.post(url(controller='login', action='index'),
{'username': TEST_USER_ADMIN_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_ADMIN_PASS})
self.assertEqual(response.status, '302 Found')
self.assertEqual(response.session['authuser'].get('username'),
TEST_USER_ADMIN_LOGIN)
@@ -41,7 +41,7 @@ class TestLoginController(TestController
def test_login_regular_ok(self):
response = self.app.post(url(controller='login', action='index'),
{'username': TEST_USER_REGULAR_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_REGULAR_PASS})
self.assertEqual(response.status, '302 Found')
self.assertEqual(response.session['authuser'].get('username'),
@@ -54,7 +54,7 @@ class TestLoginController(TestController
response = self.app.post(url(controller='login', action='index',
came_from=test_came_from),
{'username': TEST_USER_ADMIN_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_ADMIN_PASS})
self.assertEqual(response.status, '302 Found')
response = response.follow()
@@ -64,7 +64,7 @@ class TestLoginController(TestController
def test_logout(self):
response = self.app.post(url(controller='login', action='index'),
{'username': TEST_USER_REGULAR_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_REGULAR_PASS})
# Verify that a login session has been established.
response = self.app.get(url(controller='login', action='index'))
@@ -88,7 +88,7 @@ class TestLoginController(TestController
response = self.app.post(url(controller='login', action='index',
came_from=url_came_from),
{'username': TEST_USER_ADMIN_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_ADMIN_PASS})
self.assertEqual(response.status, '302 Found')
self.assertEqual(response._environ['paste.testing_variables']
['tmpl_context'].came_from, '/')
@@ -150,7 +150,7 @@ class TestLoginController(TestController
came_from = '/_admin/users',
**args),
{'username': TEST_USER_ADMIN_LOGIN,
- 'password': 'test12'})
+ 'password': TEST_USER_ADMIN_PASS})
self.assertEqual(response.status, '302 Found')
for encoded in args_encoded:
self.assertIn(encoded, response.location)
diff --git a/kallithea/tests/functional/test_my_account.py b/kallithea/tests/functional/test_my_account.py
--- a/kallithea/tests/functional/test_my_account.py
+++ b/kallithea/tests/functional/test_my_account.py
@@ -153,7 +153,7 @@ class TestMyAccountController(TestContro
response = self.app.post(url('my_account'),
params=dict(
username=TEST_USER_ADMIN_LOGIN,
- new_password='test12',
+ new_password=TEST_USER_ADMIN_PASS,
password_confirmation='test122',
firstname='NewName',
lastname='NewLastname',
@@ -164,13 +164,13 @@ class TestMyAccountController(TestContro
response.mustcontain('This e-mail address is already taken')
def test_my_account_update_err(self):
- self.log_user(TEST_USER_REGULAR2_LOGIN, 'test12')
+ self.log_user(TEST_USER_REGULAR2_LOGIN, TEST_USER_REGULAR2_PASS)
new_email = 'newmail.pl'
response = self.app.post(url('my_account'),
params=dict(
username=TEST_USER_ADMIN_LOGIN,
- new_password='test12',
+ new_password=TEST_USER_ADMIN_PASS,
password_confirmation='test122',
firstname='NewName',
lastname='NewLastname',
@@ -185,7 +185,7 @@ class TestMyAccountController(TestContro
response.mustcontain(u"%s" % msg)
def test_my_account_api_keys(self):
- usr = self.log_user(TEST_USER_REGULAR2_LOGIN, 'test12')
+ usr = self.log_user(TEST_USER_REGULAR2_LOGIN, TEST_USER_REGULAR2_PASS)
user = User.get(usr['user_id'])
response = self.app.get(url('my_account_api_keys'))
response.mustcontain(user.api_key)
@@ -197,7 +197,7 @@ class TestMyAccountController(TestContro
('30days', 60*60*24*30),
])
def test_my_account_add_api_keys(self, desc, lifetime):
- usr = self.log_user(TEST_USER_REGULAR2_LOGIN, 'test12')
+ usr = self.log_user(TEST_USER_REGULAR2_LOGIN, TEST_USER_REGULAR2_PASS)
user = User.get(usr['user_id'])
response = self.app.post(url('my_account_api_keys'),
{'description': desc, 'lifetime': lifetime, '_authentication_token': self.authentication_token()})
@@ -213,7 +213,7 @@ class TestMyAccountController(TestContro
Session().commit()
def test_my_account_remove_api_key(self):
- usr = self.log_user(TEST_USER_REGULAR2_LOGIN, 'test12')
+ usr = self.log_user(TEST_USER_REGULAR2_LOGIN, TEST_USER_REGULAR2_PASS)
user = User.get(usr['user_id'])
response = self.app.post(url('my_account_api_keys'),
{'description': 'desc', 'lifetime': -1, '_authentication_token': self.authentication_token()})
@@ -232,7 +232,7 @@ class TestMyAccountController(TestContro
def test_my_account_reset_main_api_key(self):
- usr = self.log_user(TEST_USER_REGULAR2_LOGIN, 'test12')
+ usr = self.log_user(TEST_USER_REGULAR2_LOGIN, TEST_USER_REGULAR2_PASS)
user = User.get(usr['user_id'])
api_key = user.api_key
response = self.app.get(url('my_account_api_keys'))
diff --git a/kallithea/tests/scripts/manual_test_concurrency.py b/kallithea/tests/scripts/manual_test_concurrency.py
--- a/kallithea/tests/scripts/manual_test_concurrency.py
+++ b/kallithea/tests/scripts/manual_test_concurrency.py
@@ -55,7 +55,7 @@ load_environment(conf.global_conf, conf.
add_cache(conf)
USER = TEST_USER_ADMIN_LOGIN
-PASS = 'test12'
+PASS = TEST_USER_ADMIN_PASS
HOST = 'server.local'
METHOD = 'pull'
DEBUG = True
More information about the kallithea-general
mailing list