[PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

Mads Kiilerich mads at kiilerich.com
Sat Jun 20 17:50:11 EDT 2015


On 06/20/2015 10:37 PM, Thomas De Schampheleire wrote:
> Some trivial cleanups related to hardcoded strings in tests.

I think another school of thought is that tests should be as simple, 
static and explicit as possible. To avoid begging the question they are 
asking, they should avoid any computation in the tests. Having hardcoded 
'expected' strings will also make it easier when debugging.

Anyway, I don't know if I agree and I don't know if it should be taken 
to the extreme, so I think these changes are fine.

/Mads


More information about the kallithea-general mailing list