[PATCH 08 of 19] autocomplete: clean up handlers for itemSelectEvent

[Thomas De Schampheleire]

On Tue, Jul 14, 2015 at 12:57 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
> On 06/30/2015 10:43 PM, Thomas De Schampheleire wrote:
>>
>> # HG changeset patch
>> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
>> # Date 1435349220 -7200
>> #      Fri Jun 26 22:07:00 2015 +0200
>> # Node ID 98519504e88827b408447efcb9ea01ca270a7b0b
>> # Parent  623155b700e275d039d1a9065f272dc6fa4fb569
>> autocomplete: clean up handlers for itemSelectEvent
>>
>> The handlers that execute when an autocompleted item is selected are
>> really
>> specific and cannot be factored out. Nevertheless, some cleanup:
>>
>> - rationalize indentation
>> - remove checks on the existence of xAC.itemSelectEvent: there seems to be
>>    no reason at all to check this, the YUI documentation also does not
>>    mention it.
>
>
> Grumpy users tell me that itemSelectEvent can be null. I cannot reproduce it
> ... but a blind fix restoring the check made them happy.
>
> Have you tried testing this with a wider audience?

Hmm, was this with the entire patch series applied?
I have seen such a problem when the members autocomplete was still
handling two different autocomplete instances, but after splitting
that it was fixed...

On which page do they see it?

And are you sure that they don't suffer from browser caching?

This series was not tested in production, no..

/Thomas