[PATCH 13 of 19] autocomplete: fix completion of repository owner

Mads Kiilerich mads at kiilerich.com
Thu Jul 16 16:43:29 UTC 2015


On Tue, Jun 30, 2015 at 10:43 PM, Thomas De Schampheleire <
patrickdepinguin at gmail.com> wrote:

> # HG changeset patch
> # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
> # Date 1435592559 -7200
> #      Mon Jun 29 17:42:39 2015 +0200
> # Node ID f1d674589538cbf1c6d066b203016009d7c679b2
> # Parent  2d3ead418f13410650da664144462a54a0312163
> autocomplete: fix completion of repository owner
>
> The owner field of a repository setting was supposed to be autocompletable,
> but never really did (at least not in Kallithea, probably it once did in
> Rhodecode).
>
> Instead of making yet another 'OwnerAutoComplete', make a generic
> SimpleUserAutoComplete that can be reused in other places that only need
> completion of a text input field.
>
> diff --git a/kallithea/controllers/admin/repos.py
> b/kallithea/controllers/admin/repos.py
> --- a/kallithea/controllers/admin/repos.py
> +++ b/kallithea/controllers/admin/repos.py
> @@ -370,6 +370,8 @@ class ReposController(BaseRepoController
>
>          c.repo_fields = RepositoryField.query()\
>              .filter(RepositoryField.repository == c.repo_info).all()
> +        repo_model = RepoModel()
> +        c.users_array = repo_model.get_users_js()
>          c.active = 'settings'
>          return htmlfill.render(
>              render('admin/repos/repo_edit.html'),
>

This fails for all the other places where repo_edit.html is used.

/Mads
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20150716/7f9f6034/attachment.html>


More information about the kallithea-general mailing list