[PATCH 13 of 19] autocomplete: fix completion of repository owner

[Thomas De Schampheleire]

On July 16, 2015 8:35:13 PM CEST, Mads Kiilerich <mads at kiilerich.com> wrote:
>On 07/16/2015 06:43 PM, Mads Kiilerich wrote:
>> On Tue, Jun 30, 2015 at 10:43 PM, Thomas De Schampheleire 
>> <patrickdepinguin at gmail.com <mailto:patrickdepinguin at gmail.com>>
>wrote:
>>
>>     # HG changeset patch
>>     # User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com
>>     <mailto:thomas.de.schampheleire at gmail.com>>
>>     # Date 1435592559 -7200
>>     #      Mon Jun 29 17:42:39 2015 +0200
>>     # Node ID f1d674589538cbf1c6d066b203016009d7c679b2
>>     # Parent  2d3ead418f13410650da664144462a54a0312163
>>     autocomplete: fix completion of repository owner
>>
>>     The owner field of a repository setting was supposed to be
>>     autocompletable,
>>     but never really did (at least not in Kallithea, probably it once
>>     did in
>>     Rhodecode).
>>
>>     Instead of making yet another 'OwnerAutoComplete', make a generic
>>     SimpleUserAutoComplete that can be reused in other places that
>>     only need
>>     completion of a text input field.
>>
>>     diff --git a/kallithea/controllers/admin/repos.py
>>     b/kallithea/controllers/admin/repos.py
>>     --- a/kallithea/controllers/admin/repos.py
>>     +++ b/kallithea/controllers/admin/repos.py
>>     @@ -370,6 +370,8 @@ class ReposController(BaseRepoController
>>
>>              c.repo_fields = RepositoryField.query()\
>>                  .filter(RepositoryField.repository ==
>c.repo_info).all()
>>     +        repo_model = RepoModel()
>>     +        c.users_array = repo_model.get_users_js()
>>              c.active = 'settings'
>>              return htmlfill.render(
>>                  render('admin/repos/repo_edit.html'),
>>
>>
>> This fails for all the other places where repo_edit.html is used.
>
>More specifically:
>c.users_array is also needed for form validation errors on failing
>updates.
>
>I don't know if it is needed in more places ... apparently not.

I'm not near the code so cannot fully grasp of what you say, will check that tomorrow.

>
>It would be nice if this users list always was available for
>computation 
>on demand from the templates. Or ultimately, for scaling to a huge site
>
>where it not is feasible to fetch all users, we would have to send 
>queries to the server and just get the few results back. The same 
>applies to many other lists or template data.

Yes, I fully agree, the data should be fetched with ajax. Both YUI as jQuery support this.
I think we should first fix the issues with my current series, merge it, then plan for further removal of yui. Although for the last part, we may need to prioritize against other items first.

/Thomas