[PATCH 2 of 8] admin: e-mail: remove display of SMTP password

Thomas De Schampheleire patrickdepinguin at gmail.com
Wed Jul 22 19:50:02 UTC 2015


# HG changeset patch
# User Thomas De Schampheleire <thomas.de.schampheleire at gmail.com>
# Date 1437508363 -7200
#      Tue Jul 21 21:52:43 2015 +0200
# Node ID f219f0a41f57655dd2125c9371db9ee1ac217a4b
# Parent  27fbaba10257132c1087a3dc7f7c2bdfd4b5ab9e
admin: e-mail: remove display of SMTP password

It is quite useless, and in a way a security leak, to display the length of
the SMTP password when showing the e-mail settings.
Removing any reference to the SMTP password has the additional advantage of
making subsequent cleanup on this page easier.

diff --git a/kallithea/templates/admin/settings/settings_email.html b/kallithea/templates/admin/settings/settings_email.html
--- a/kallithea/templates/admin/settings/settings_email.html
+++ b/kallithea/templates/admin/settings/settings_email.html
@@ -8,7 +8,6 @@
 
     (_('SMTP server'), c.ini.get('smtp_server'), ''),
     (_('SMTP username'), c.ini.get('smtp_username'), ''),
-    (_('SMTP password'), '%s chars' % len(c.ini.get('smtp_password', '')), ''),
     (_('SMTP port'), c.ini.get('smtp_port'), ''),
 
     (_('SMTP use TLS'), c.ini.get('smtp_use_tls'), ''),


More information about the kallithea-general mailing list