[PATCH] login: always pass server-relative URLs in came_from

[Thomas De Schampheleire]

On September 18, 2015 5:37:44 PM GMT+02:00, Mads Kiilerich <mads at kiilerich.com> wrote:
>On 09/18/2015 05:09 PM, Thomas De Schampheleire wrote:
>>
>> On September 18, 2015 3:03:01 PM GMT+02:00, "Søren Løvborg"
><sorenl at unity3d.com> wrote:
>>> Here's an alternative to Andrew's patch, which fixes both the prefix
>>> problem and a few others.
>>>
>>> There's a lot more churn, especially in the test suite, but
>all-in-all
>>> the result is a 20-line reduction. A test that prefix redirects
>>> actually
>>> work should probably be added; for now, it's been verified manually.
>> A test would indeed be great... You or Andrew interested?
>
>It seems like we have plenty of tests. They were just testing the wrong
>
>logic.

Then we should fix these, of course. The tests I added were focused on the GET 
argument propagation, I was not aware about the different deployment scenarios 
and how this would impact the behavior.

/Thomas