Showing who approved (or not) a revision

[Mads Kiilerich]

On 02/13/2016 11:44 PM, Angel Ezquerra wrote:
> Hi,
>
> does Kallithea save the id of the user who last changed the review
> status of a changest? I think it would be really useful if you could
> somehow see (e.g. via a tooltip or directly on the changeset list) who
> approved (or rejected, etc) a given changeset.
>
> I tried to find where it is set or stored by it was not
> straightforward. Pointers would be welcome.

The html templates like
https://kallithea-scm.org/repos/kallithea/files/2f14b4db03626c6eb2fd9b6f541d74c96de0178a/kallithea/templates/changelog/changelog.html#L88 
uses a data structure coming from 
https://kallithea-scm.org/repos/kallithea/files/2f14b4db03626c6eb2fd9b6f541d74c96de0178a/kallithea/model/db.py#L1398 
. I guess it could be extended to also contain user info. It would 
probably be nice to first refactor it to not use "tuples".

(Generally, I think it is debatable how useful "latest reviewer" is ... 
but for now that is how it is. The database model for comments and 
status also has a lot of room for improvement.)

/Mads