[PATCH] changeset: add link to main (status change) form from changeset status

[Angel Ezquerra]

On Mon, Feb 22, 2016 at 8:15 AM, Angel Ezquerra
<angel.ezquerra at gmail.com> wrote:
> # HG changeset patch
> # User Angel Ezquerra <angel.ezquerra at gmail.com>
> # Date 1456074926 -3600
> #      Sun Feb 21 18:15:26 2016 +0100
> # Branch stable
> # Node ID 17dd4d5bff87a60b34db82e8ae9675acac138fee
> # Parent  f1e465120793c9c7cad6baa4d78a00155bac4311
> changeset: add link to main (status change) form from changeset status
>
> Add a link to the changeset status indicator (at the top of thee changeset page)
> pointing to the main (status change) form. This should make it easier to change
> the status (e.g. to under review). It also makes it easier to go to the comments
> section.
>
> diff --git a/kallithea/templates/changeset/changeset.html b/kallithea/templates/changeset/changeset.html
> --- a/kallithea/templates/changeset/changeset.html
> +++ b/kallithea/templates/changeset/changeset.html
> @@ -47,8 +47,15 @@
>              <div class="code-header banner">
>                  <div class="changeset-status-container">
>                      %if c.statuses:
> +                        <%
> +                        status_title = _('Changeset status\nLogin to change it')
> +                        if c.authuser.username != 'default':
> +                            status_title = _('Changeset status\nClick to change it')
> +                        %>
> +                        <a href="#main_form" title="${status_title}" >
>                          <span class="changeset-status-ico"><i class="icon-circle changeset-status-${c.statuses[0]}"></i></span>
> -                        <span title="${_('Changeset status')}" class="changeset-status-lbl">[${h.changeset_status_lbl(c.statuses[0])}]</span>
> +                        <span class="changeset-status-lbl">[${h.changeset_status_lbl(c.statuses[0])}]</span>
> +                        </a>
>                      %endif
>                  </div>
>                  <div class="diff-actions">

Any comments on this patch?

Cheers,

Angel