Turbogears2 migration: preparatory changes to Pylons-based Kallithea

Mads Kiilerich mads at kiilerich.com
Tue Sep 13 23:16:31 UTC 2016


On 09/13/2016 09:20 PM, Thomas De Schampheleire wrote:
> All,
>
> I sent out a few changes for review at:
> https://kallithea-scm.org/repos/kallithea/pull-request/60/_/Turbogears2_migration_preparatory_commits
>
> These commits are originating from the tg2 branch, and can already be
> applied on current Pylons-based Kallithea. Goal of this delivery is to
> make the 'real' Turbogears2 migration a smaller, more clear diff.
>
> Turbogears2 migration: replace pylons.url by kallithea.lib.utils.url
> Turbogears2 migration: use sqlalchemy.url iso sqlalchemy.db1.url
> Turbogears2 migration: remove some references to Pylons in comments
>
> Comments welcome,

My immediate comment: This is a beautiful example of how bits and pieces 
of a big and almost-impossible-to-review amount of work can be extracted 
into clean patches and how it can make it possible to review both this 
and the remaining part much more efficiently and reliably. Thanks!

/Mads


More information about the kallithea-general mailing list