How to close a PR without opening it

[Thomas De Schampheleire]

Hi,

Some input from my side:

2017-07-07 17:14 GMT+02:00 Long Vu <long.vu at intelerad.com>:
> Hi,
>
> One of the user created a PR with a diff so gigantic (it was an
> accident, diffing an old branch to trunk) that it takes Kallithea over
> 5 mins to generate the PR page and also crash the browser because too
> much data is returned.
>
> We can not close the PR because the close button is inside the PR (so
> have to load the PR but that PR is crashing the browser).
>
> Is there another way (maybe direct DB manipulation or another location
> to access that delete button) to close the PR?
>

The direct database manipulation is indeed a possibility. I haven't
done deletion via db, although I closed (not deleted) many already.
Recently, I have used it as admin for a large batch of PRs that had to
be closed, because the original respective owners left the company
while the PRs were still open.

Regarding deletion via the 'My pull requests' page: I find the
'delete' button for the owner too inviting. In fact, I consider the
need for deleting a PR a highly exceptional situation, purely reserved
for wrong/accidental creation of a PR. For all other uses, PRs that
are no longer needed should be closed, rather than deleted.

This topic was also discussed at an earlier occasion. I think one idea
was forbidding deleting a PR that has had activity, e.g. comments or
status changes, for regular owners. Admins should still be able to do
it, though, via the web UI and obviously via direct database access.

To improve the management aspect for admins, avoiding the need for
direct db access, perhaps a UI page could be added, allowing to filter
PRs on different criteria and with checkboxes and buttons to allow
(batch) closing and deletion.
Perhaps, the filtering aspect would be useful for regular users too...

/Thomas