Side-by-side diff broken in some browsers

[Thomas De Schampheleire]

Hi Dominik,

After upgrading our Kallithea to something based on almost latest
default branch, we noticed an issue with side-by-side diff in some
browsers, e.g.
- Firefox 52 (Windows)
- Chrome 63 (Windows)

I don't see the issue on:
- Firefox 57 (Linux)

The issue is that the right pane does not seem to contain any code,
and as such there is no diff.
Please see screenshots. Second screenshot is same page as first but
scrolled down a bit.

I bisected the issue down to the commit below.
I confirmed that by removing that block on the latest default, two-way
diff works fine again. However, I don't know what else I broke now.

Best regards,
Thomas


# HG changeset patch
# User domruf <dominikruf at gmail.com>
# Date 1509208744 -7200
#      Sat Oct 28 18:39:04 2017 +0200
# Node ID eee7674cef4126d3ad15754992ac1eb20f4587d8
# Parent  5a5398a5bf831d33808e0d6261a0516b27366cd2
less: prevent elements from overflowing panels

diff --git a/kallithea/public/css/style.css b/kallithea/public/css/style.css
--- a/kallithea/public/css/style.css
+++ b/kallithea/public/css/style.css
@@ -102,6 +102,12 @@ nav.navbar #logo > .navbar-brand > img {
   margin-top: -9px;
   margin-right: 5px;
 }
+/* every direct child of a panel, that is not .panel-heading, should auto
+ * overflow to prevent overflowing of elements like text boxes and tables */
+.panel > :not(.panel-heading) {
+  overflow-x: auto;
+  min-height: 0.01%;
+}
 /* language bars (summary page) */
 #lang_stats .progress-bar {
   min-width: 15px;
diff --git a/kallithea/public/less/style.less b/kallithea/public/less/style.less
--- a/kallithea/public/less/style.less
+++ b/kallithea/public/less/style.less
@@ -111,6 +111,13 @@ nav.navbar #logo > .navbar-brand > img {
   margin-right: 5px;
 }

+/* every direct child of a panel, that is not .panel-heading, should auto
+ * overflow to prevent overflowing of elements like text boxes and tables */
+.panel > :not(.panel-heading){
+  overflow-x: auto;
+  min-height: 0.01%;
+}
+
 /* language bars (summary page) */
 #lang_stats {
   .progress-bar {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twoway-diff-1.png
Type: image/png
Size: 46459 bytes
Desc: not available
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20180129/ab78dfd6/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: twoway-diff-2.png
Type: image/png
Size: 42289 bytes
Desc: not available
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20180129/ab78dfd6/attachment-0003.png>