PR firstline overflow

[Thomas De Schampheleire]

2018-02-22 19:14 GMT+01:00 Dominik Ruf <dominikruf at gmail.com>:
>
>
> Mads Kiilerich <mads at kiilerich.com> schrieb am Mi., 21. Feb. 2018 um 17:42
> Uhr:
>>
>> On 02/21/2018 01:45 PM, Thomas De Schampheleire wrote:
>> >> (Now, I think it would be good to also have the "expand" button move
>> >> from a
>> >> separate column to be shown as the first label ...)
>> > but that would mean that they would no longer be vertically aligned
>> > across commits. I think that would make it a bit less user-friendly.
>>
>> But while it is important to be able to visually scroll through a list
>> of changesets and look for dates, committer, or read the commit message,
>> it is much more rare to want to scan through the changeset list and spot
>> those with multi-line commit messages. Usually, you read the first line
>> of a commit message from the beginning and as far as you can, and then
>> you realize there is more and you want to read it ... and then you have
>> the button right there where your eyes are.
>
> I agree with Mads. In fact earlier PRs of my  bootstrap stuff had the expand
> button behind the first line.
> I also think a clickable '...' button behind the text (like on github) would
> be more intuitive then the current 'align-left' icon.


Fair enough, I can follow this reasoning of putting an icon to the right.

I'm also open to changing the icon to something with '...' or some
other expand-like icon.

/Thomas