Kallithea 0.3.99 Default Branch verify commit

[Matey Chopov]

Hi Thomas,

I confirm, there is no '.hg/hgrc' file in the repository, it seems like that's the main cause of the issue. The repository was created via the Kallithea web interface.

If I remove the if condition in the simplehg.py file and I put a dummy hgrc file in the repo it works.

Thanks,

Mat

-----Original Message-----
From: Thomas De Schampheleire [mailto:patrickdepinguin at gmail.com] 
Sent: Monday, August 20, 2018 4:25 PM
To: Matey Chopov <matey.chopov at ca.abb.com>; Mads Kiilerich <mads at kiilerich.com>
Cc: Kallithea <kallithea-general at sfconservancy.org>
Subject: Re: Kallithea 0.3.99 Default Branch verify commit

Hi,

Can you confirm that in the repository you are cloning, there is no '.hg/hgrc' file (to check on the server filesystem)?
This is the only condition in which 'make_ui' (which is used to fill
repoui) returns a False value. I had missed that during review of this change.

In that case, I think that your fix (restoring the 'if' check) seems correct. If there is no hgrc file, there is no need in importing its contents.

Mads to confirm...

/Thomas


El lun., 20 ago. 2018 a las 21:43, Matey Chopov
(<matey.chopov at ca.abb.com>) escribió:
>
> Hi guys,
>
>
>
> I cloned the default branch today on our Kallithea test server and when I tried cloning a random repo from our server, I got an HTTP Error: 500 (Internal Server error) and this stack trace:
>
>
>
> Traceback (most recent call last):
>
>   File 
> "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support
> /registry.py", line 253, in __call__
>
>     app_iter = self.application(environ, start_response)
>
>   File 
> "/home/kallithea/kallithea-venv/lib/python2.7/site-packages/tg/support
> /middlewares.py", line 135, in __call__
>
>     return self._stream_response(self.app(environ, start_response))
>
>   File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in 
> __call__
>
>     return self._handle_request(environ, start_response)
>
>   File 
> "/home/kallithea/kallithea/kallithea/lib/middleware/simplegit.py", 
> line 69, in _handle_request
>
>     return self.application(environ, start_response)
>
>   File "/home/kallithea/kallithea/kallithea/lib/base.py", line 364, in 
> __call__
>
>     return self._handle_request(environ, start_response)
>
>   File 
> "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 
> 143, in _handle_request
>
>     self._augment_hgrc(repo_path, baseui)
>
>   File 
> "/home/kallithea/kallithea/kallithea/lib/middleware/simplehg.py", line 
> 229, in _augment_hgrc
>
>     for k, v in repoui.configitems(section):
>
> AttributeError: 'bool' object has no attribute 'configitems'
>
>
>
> I checked the latest commits and I think the issue may be related to 
> this one: 
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkal
> lithea-scm.org%2Frepos%2Fkallithea%2Fchangeset%2F89c30b145bb8a4151c115
> 4c42c4e9ec23ff442f8&data=02%7C01%7Cmatey.chopov%40ca.abb.com%7Caa7
> b2fed09924988e90408d606daceed%7C372ee9e09ce04033a64ac07073a91ecd%7C0%7
> C0%7C636703934179574600&sdata=5u5UIz9XJ37k1peET0hmY43eZ9rmV2KFbE8l
> xSGDgY8%3D&reserved=0
>
>
>
> If I add back line 240 (if repoui: ) which was removed from simplehg.py and I keep the other changes from the commit everything works, but if I comment that line I get the ‘bool’ exception.
>
>
>
> Can you confirm?
>
>
>
> Thanks,
>
>
>
> Mat
>
>
>
>
>
>
>
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> ts.sfconservancy.org%2Fmailman%2Flistinfo%2Fkallithea-general&data
> =02%7C01%7Cmatey.chopov%40ca.abb.com%7Caa7b2fed09924988e90408d606dacee
> d%7C372ee9e09ce04033a64ac07073a91ecd%7C0%7C0%7C636703934179574600&
> sdata=sAscNeMSiZZNUdipZjH6XkwuEVQVfXmxJuTbFVQ1y14%3D&reserved=0