[PATCH 0 of 9] remove UI notification feature

Mads Kiilerich mads at kiilerich.com
Thu Dec 6 11:26:35 UTC 2018


Thanks.

I wonder if some css also could be cleaned up?

And we have so much cruft in upgraded databases anyway. I think we 
either should accept a bit more tech debt there and rely on a future 
"only preserve schema things we use now" database migration option, or 
just add a migration step now to drop these tables. I don't think the 
comment helps - it is not a list that can be trusted anyway.

About the if condition indentation: I think we have the same deficiency 
in many other places. Perhaps, when the number of outstanding patches 
are at a low, we should just start using 
https://black.readthedocs.io/en/stable/the_black_code_style.html .

/Mads



More information about the kallithea-general mailing list