[PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

Mads Kiilerich mads at kiilerich.com
Sun Feb 9 16:05:54 UTC 2020


On 2/8/20 9:21 PM, Ross Thomas wrote:
> On 2/8/20 6:05 AM, Mads Kiilerich wrote:
>> Thanks. I do agree this is better. But is it fixing an actual problem?
>> The old manual encoding seems to work fine too?
> Yep, it worked but it was mostly fortunate 'luck'.  It ended up using
> matrix mode instead of true query params.


Interesting. I had never heard about "matrix mode". 
https://www.w3.org/DesignIssues/MatrixURIs.html . That idea was 
stillborn. Quite unfortunate that urllib.parse implement it without any 
documentation or code comments. I guess that will bite some users, and 
perhaps in some cases cause security issues in some applications.

Thanks for the patch.

/Mads




More information about the kallithea-general mailing list