[PATCH 1 of 1] ui: Add support for 'quick' action icons in repo browser

[Thomas De Schampheleire]

Hi Ross, Mads,

On Mon, Feb 10, 2020, 22:48 Ross Thomas <ross at lns-nevasoft.com> wrote:

> # HG changeset patch
> # User Ross Thomas <ross at lns-nevasoft.com>
> # Date 1581113799 28800
> #      Fri Feb 07 14:16:39 2020 -0800
> # Branch stable
> # Node ID 0c6914676f88f7fae5818e27ae65c15ef45fba88
> # Parent  f273a7b53fe035c12a55b6a3e34f849af245d797
> ui: Add support for 'quick' action icons in repo browser
> config: Add new value 'repo_list_quick_actions' to enable/disable 'quick'
> action icons in repo browser
>
> When setting 'repo_list_quick_actions' to a true value a new 'Action'
> column is added
> to the repo list browser that contains quick action icons.  These quick
> icons provide
> direct access to selected repo operations:
>    - (heart icon) Toggle user's follow state for the repo
>    - (fork icon) Open the repo's Fork page
>    - (gear icon) Open the repo's Settings page (present if user is admin
> for repo)
>
> diff -r f273a7b53fe0 -r 0c6914676f88 development.ini
> --- a/development.ini   Fri Feb 07 13:55:27 2020 -0800
> +++ b/development.ini   Fri Feb 07 14:16:39 2020 -0800
> @@ -227,6 +227,9 @@
>  #    INSTALL
>  #    CHANGELOG
>
> +## adds 'quick' action icons to repos listed in the repository browsing
> pages.
> +repo_list_quick_actions = False
>

Configuration can happen in two places in Kallithea: in the ini file, or in
the database via the UI.
The first method requires a Kallithea restart and access to the (unix) user
that runs Kallithea.
The second method does not need a restart and can be done by any admin.

It is my belief that ini changes should be reserved for things where a
restart is mandatory, or where the configuration item conceptually belongs
to the user that sets up kallithea.

Especially for UI changes or other behavioral changes, I think a setting in
the UI would be better. (Granted, there may be other settings in the ini
file that should better be moved).

Best regards
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sfconservancy.org/pipermail/kallithea-general/attachments/20200211/f2825969/attachment.html>