memory leak stikes back

[Łukasz Michalski]

On 01/09/2020 09.29, Thomas De Schampheleire wrote:
> Hi Łukasz,
>
> Sorry to have given you confusing information.
>
> The code snippet I had looked at was:
> (kallithea/lib/paster_commands/template.ini.mako)
>
> %if http_server == 'gearbox':
> <%text>##</%text> Gearbox default web server ##
> use = egg:gearbox#wsgiref
> <%text>##</%text> nr of worker threads to spawn
> threadpool_workers = 1
> <%text>##</%text> max request before thread respawn
> threadpool_max_requests = 100
> <%text>##</%text> option to use threads of process
> use_threadpool = true
>
> [..]
>
> %elif http_server == 'waitress':
> <%text>##</%text> WAITRESS ##
> use = egg:waitress#main
> <%text>##</%text> number of worker threads
> threads = 1
> <%text>##</%text> MAX BODY SIZE 100GB
> max_request_body_size = 107374182400
> <%text>##</%text> use poll instead of select, fixes fd limits, may not work on old
> <%text>##</%text> windows systems.
> #asyncore_use_poll = True
>
> [..]
>
> %endif
>
>
> The directive 'threadpool_max_requests' that I was referring to is an option to the 'gearbox' http server, not 'waitress'. Also the 'gunicorn' server has a similar option set, but it seems that 'waitress' does not support something directly (https://docs.pylonsproject.org/projects/waitress/en/stable/arguments.html).
>
> But 'waitress' is the default setting for kallithea-cli config-create.
>
> You can try another server using:
> kallithea-cli config-create foo.ini http_server=gearbox
>
> and replace gearbox by the one you would like to choose. Valid options are: waitress, gearbox, gevent, gunicorn, uwsgi .
>
> In my own production instance I'm using uwsgi.
>
>
> Mads: I wonder if we should do something about the default 'waitress' setting?
>
> Thanks,
> Thomas
>
Ok, thanks. Meanwhile I added systemd timer and service to restart kallithea once a week.
I think it would be worth doing something about default configuration to prevent memory leaks like this. Do you have such problems with uwsgi configuration?

Regards,
Łukasz