Re: [PATCH stable] vcs: use correct name of parameter “reverse” in docstring of get_changesets()

[Mads Kiilerich]

Pushed to stable - thanks.

These auto generated doc strings have no value and adds a maintenance 
burden. It would be equally good to just remove them.

/Mads



On 2/26/22 05:24, Manuel Jacob wrote:
> # HG changeset patch
> # User Manuel Jacob <me at manueljacob.de>
> # Date 1645849430 -3600
> #      Sat Feb 26 05:23:50 2022 +0100
> # Branch stable
> # Node ID 2ea1e41d5d870cf3e2333ae541408129b5494120
> # Parent  397f73d1cdd4b39c9c17bb8d45592e866fcab88c
> vcs: use correct name of parameter “reverse” in docstring of get_changesets()
>
> diff --git a/kallithea/lib/vcs/backends/base.py b/kallithea/lib/vcs/backends/base.py
> --- a/kallithea/lib/vcs/backends/base.py
> +++ b/kallithea/lib/vcs/backends/base.py
> @@ -171,7 +171,7 @@
>           :param start_date:
>           :param end_date:
>           :param branch_name:
> -        :param reversed:
> +        :param reverse:
>           """
>           raise NotImplementedError
>   
> diff --git a/kallithea/lib/vcs/backends/hg/repository.py b/kallithea/lib/vcs/backends/hg/repository.py
> --- a/kallithea/lib/vcs/backends/hg/repository.py
> +++ b/kallithea/lib/vcs/backends/hg/repository.py
> @@ -523,7 +523,7 @@
>           :param start_date:
>           :param end_date:
>           :param branch_name:
> -        :param reversed: return changesets in reversed order
> +        :param reverse: return changesets in reversed order
>           """
>           start_raw_id = self._get_revision(start)
>           start_pos = None if start is None else self.revisions.index(start_raw_id)
> _______________________________________________
> kallithea-general mailing list
> kallithea-general at sfconservancy.org
> https://lists.sfconservancy.org/mailman/listinfo/kallithea-general