[PATCH 1 of 2 stable v3] tests: set Git author and committer name and email settings explicitly

Manuel Jacob me at manueljacob.de
Thu Apr 20 11:55:01 UTC 2023


On 20/04/2023 11.19, Mads Kiilerich wrote:
> On 20/04/2023 01:30, Manuel Jacob wrote:
>> On 20/04/2023 01.07, Mads Kiilerich wrote:
>>> Thanks - this looks much more approachable.
>>>
>>> But while processing v2 and our discussion and trying to give good 
>>> input to what I would like to see in v3, I figured it perhaps would 
>>> be better with a simpler solution.
>>>
>>> What do you think about doing it as in 
>>> https://kallithea-scm.org/repos/kallithea-incoming/changelog/61393fa29552/?size=2 ? (Possibly incorporating some of the new summary in v3?)
>>
>> Implementation-wise, either would be fine for me, as long as the 
>> solution avoids system-dependent behavior (in that aspect, both 
>> implementations are equivalently good).
>>
>> My changeset description is a bit more extensive. I’ll let you decide 
>> if merging the two patches is worth the effort in case you decide for 
>> your implementation.
> 
> 
> Thanks for the collaboration. I pushed a mix of the two approaches.

Looks good!

> /Mads
> 



More information about the kallithea-general mailing list