Patch bomb from Unity Technologies

[Sean Farley]

Mads Kiilerich writes:

> At Unity Technologies we are using Kallithea internally. Many of our 
> changes have been upstreamed, some have not. It is changes that make 
> Kallithea work for our scale and our way of doing things but these 
> changes should however also be of general use. Some of the changes have 
> been used in production for more than a year, some only after the 
> upgrade to Kallithea.
>
> Please dig into 
> https://bitbucket.org/conservancy/kallithea/pull-request/4/patches-from-unity/commits 
> and give some feedback.
>
> All the changes should be self contained and review-able one by one. It 
> is changes that have different topics, but splitting them up and 
> reordering them further would probably not add much value.

I have finally gotten around to reviewing this pull request. These
changes are great and should be merged!

My only comments are small nits about styling the commit message to have
the first line less than 80 characters but that shouldn't block this
merge. Instead, I would suggest bikeshedding a code-style guide for
would-be contributors.

A few notes I made while reviewing:

- most style choices (indentation, css, if-blocks in html) are inherited
  so others should feel free to send patches later to clean that up

- I like 38ec32b1ef50 and will use that for my evolution changesets

- The biggest change is probably 4666729c8bb8 since it allows pull
  requests to be updated to a new one. I think this is great and should
  use mercurial evolution in the future :-)

I like the general direction and will also use what I learned to improve
my own patches.