discussion on issue #77 (review icon position for in-line code comments)
mads at kiilerich.com
Sun Jan 25 19:37:44 EST 2015
On 01/25/2015 11:08 PM, Sean Farley wrote:
> Thomas De Schampheleire writes:
>> This mail thread is a continued discussion of issue #77
>> (in-line review icon/button should also appear when hovering over the
>> line number) 
>> The problem statement: if I place my mouse at the location where the
>> review icon normally appears, I expect it to appear.
>> Currently, this is not the case, as the icon is outside of the area
>> that triggers the icon to appear.
>> My requirement is thus:
>> a. the area containing the icon should be a hotspot that causes the
>> icon to appear.
>> Mads already hinted on some other requirements:
>> b. we don't want the icon to overlap with the code
>> c. the clickable area should be larger than the icon itself to make it
>> more easy to hit it.
>> d. we don't want to reserve additional dedicated space
>> e. we want to be able to link to a given code line
>> Your proposals are very welcome.
> I was thinking we should place the icon's center on the line that
> divides the line number from the code, a la github's look. That would
> not require too much extra space and would work as "expected".
I think I would support a patch that makes improvements i the mentined
directions while keeping the mentioned other requirements in mind.
I also think it is odd that both Bitbucket, Github and Kallithea shows
the line numbers for each line in a diff. It is usually worthless
information when reviewing through the web. If using the actual source
for reference and reviewing locally, the line number of the chunk is
more releant than the line number of every line in the diff. I thus
think we could make an even better solution if we didn't use horizontal
space for both showing line numbers for every line and also leaving
space for 'add comment' and 'link to this line' (and in the future
perhaps also for annotate information). Perhaps by overlaying the latter
on top of the first when hovering over a line.
More information about the kallithea-general