pull requests: variable names

Nick Coghlan ncoghlan at gmail.com
Sat Feb 14 23:50:53 EST 2015

On 15 February 2015 at 06:36, Thomas De Schampheleire
<patrickdepinguin at gmail.com> wrote:
> Hi,
> In the pull request code (both controllers and templates) I find the
> variable names non-intuitive and it is therefore harder to make
> changes.
> With this mail I would like to get an agreement on the terminology we
> can change to.
> - org vs other --> source/src and dest
> - c.cs_repo: what does 'cs' stand for here? This could become src_repo
> - c.a_repo: what does 'a' stand for here?? This could become dest_repo.
> Other variable names with the same prefixes 'cs'/'a'/'org'/'other'
> would be changed too, of course.

+1 from me for the general idea of having PR code focus on "src ->
dest", without making assumptions about the "src" being outside the
organisation and the "dest" being inside.


Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia

More information about the kallithea-general mailing list